Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: Source/core/css/RuleFeature.h

Issue 204873003: Factor the style invalidation tree walk out of RuleFeatureSet, and make it generic. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added explicit. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/RuleFeature.h
diff --git a/Source/core/css/RuleFeature.h b/Source/core/css/RuleFeature.h
index df44c3e2fc49b04c6b0b1c033a040df05c777998..fa3037958cebc803bde2939008d2edf747d5f1ad 100644
--- a/Source/core/css/RuleFeature.h
+++ b/Source/core/css/RuleFeature.h
@@ -76,7 +76,6 @@ public:
{
ASSERT(!classValue.isEmpty());
return m_classInvalidationSets.get(classValue);
-
}
inline bool hasSelectorForId(const AtomicString& idValue) const
@@ -87,8 +86,6 @@ public:
void scheduleStyleInvalidationForClassChange(const SpaceSplitString& changedClasses, Element*);
void scheduleStyleInvalidationForClassChange(const SpaceSplitString& oldClasses, const SpaceSplitString& newClasses, Element*);
- void computeStyleInvalidation(Document&);
-
// Clears all style invalidation state for the passed node.
void clearStyleInvalidation(Node*);
@@ -104,10 +101,14 @@ public:
Vector<RuleFeature> siblingRules;
Vector<RuleFeature> uncommonAttributeRules;
-private:
- typedef HashMap<AtomicString, RefPtr<DescendantInvalidationSet> > InvalidationSetMap;
typedef Vector<RefPtr<DescendantInvalidationSet> > InvalidationList;
typedef HashMap<Element*, OwnPtr<InvalidationList> > PendingInvalidationMap;
+
+ PendingInvalidationMap& pendingInvalidationMap();
+
+private:
+ typedef HashMap<AtomicString, RefPtr<DescendantInvalidationSet> > InvalidationSetMap;
+
struct FeatureMetadata {
FeatureMetadata()
: usesFirstLineRules(false)
@@ -140,9 +141,6 @@ private:
void addClassToInvalidationSet(const AtomicString& className, Element*);
- bool invalidateStyleForClassChange(Element*, Vector<AtomicString>&, bool foundInvalidationSet);
- bool invalidateStyleForClassChangeOnChildren(Element*, Vector<AtomicString>& invalidationClasses, bool foundInvalidationSet);
-
InvalidationList& ensurePendingInvalidationList(Element*);
FeatureMetadata m_metadata;
@@ -152,6 +150,7 @@ private:
bool m_targetedStyleRecalcEnabled;
};
+
} // namespace WebCore
#endif // RuleFeature_h
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698