cc: Compute mask draw properties directly

cc: Compute mask draw properties directly

This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.

BUG=612220
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/db6216f2c2373d41f56f495b5da1c7f55e7cbc36
Cr-Commit-Position: refs/heads/master@{#398390}

[ajuma, 2016-06-07 16:49:06]

Description was changed from

==========
cc: Compute mask draw properties directly

This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.

BUG=612220
==========

to

==========
cc: Compute mask draw properties directly

This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.

BUG=612220
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ajuma, 2016-06-07 17:57:00]

Description was changed from

==========
cc: Compute mask draw properties directly

This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.

BUG=612220
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Compute mask draw properties directly

This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.

BUG=612220
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ajuma, 2016-06-07 17:57:00]

ajuma@chromium.org changed reviewers:
+ jaydasika@chromium.org, weiliangc@chromium.org

[ajuma, 2016-06-07 17:59:39]

https://codereview.chromium.org/2048723002/diff/20001/cc/trees/draw_property_...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/2048723002/diff/20001/cc/trees/draw_property_...
cc/trees/draw_property_utils.cc:1102: gfx::Rect(mask_layer->bounds());
We were previously using the owning layer's bounds as the visible rect
(regardless of what's actually visible). Using the mask layer's own bounds seems
to make more sense. Masks are rastered as a single tile, so the only thing that
seems to matter for the visible rect is empty vs non-empty.

https://codereview.chromium.org/2048723002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common.cc (left):

https://codereview.chromium.org/2048723002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common.cc:499:
layer->draw_properties().target_space_transform;
Target space transform used to be needed to pick a contents scale, but now we're
using screen space transform for this, so masks no longer need a target space
transform.

https://codereview.chromium.org/2048723002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common.cc:505:
layer->draw_properties().starting_animation_contents_scale;
We were previously setting but never using animation contents scale (since we
were never setting screen_space_transform_is_animating), so in this patch
they're no longer computed at all for masks.

[jaydasika, 2016-06-07 18:12:04]

lgtm

[ajuma, 2016-06-07 19:51:22]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2016-06-07 20:02:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048723002/20001

[commit-bot: I haz the power, 2016-06-07 21:44:20]

Description was changed from

==========
cc: Compute mask draw properties directly

This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.

BUG=612220
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Compute mask draw properties directly

This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.

BUG=612220
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-07 21:44:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-07 21:45:53]

Description was changed from

==========
cc: Compute mask draw properties directly

This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.

BUG=612220
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Compute mask draw properties directly

This computes draw properties for mask layers directly rather than
by using the mask's owning layer's draw properties. This is a step
towards moving mask ownership to effect nodes from layers.

BUG=612220
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/db6216f2c2373d41f56f495b5da1c7f55e7cbc36
Cr-Commit-Position: refs/heads/master@{#398390}
==========

[commit-bot: I haz the power, 2016-06-07 21:45:54]

Patchset 2 (id:??) landed as
https://crrev.com/db6216f2c2373d41f56f495b5da1c7f55e7cbc36
Cr-Commit-Position: refs/heads/master@{#398390}