Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: pkg/analyzer_cli/lib/src/incremental_analyzer.dart

Issue 2048713002: Compute IGNORE_INFO and filter DART_ERRORS. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/lib/src/incremental_analyzer.dart
diff --git a/pkg/analyzer_cli/lib/src/incremental_analyzer.dart b/pkg/analyzer_cli/lib/src/incremental_analyzer.dart
index 3457fe2aab915705df4a3051867d4c703dc700a6..f9d8d4c63a7abe25fa0efe7823144d4c5dd4d363 100644
--- a/pkg/analyzer_cli/lib/src/incremental_analyzer.dart
+++ b/pkg/analyzer_cli/lib/src/incremental_analyzer.dart
@@ -131,7 +131,13 @@ class _CacheBasedResultProvider extends ResynthesizerResultProvider {
errorList.add(errors);
}
List<AnalysisError> mergedErrors = AnalysisError.mergeLists(errorList);
- entry.setValue(result, mergedErrors, TargetedResult.EMPTY_LIST);
+ // Filter the errors.
+ IgnoreInfo ignoreInfo = context.getResult(target, IGNORE_INFO);
+ LineInfo lineInfo = context.getResult(target, LINE_INFO);
+ List<AnalysisError> filteredErrors =
+ DartErrorsTask.filterIgnored(mergedErrors, ignoreInfo, lineInfo);
+ // Set the result.
+ entry.setValue(result, filteredErrors, TargetedResult.EMPTY_LIST);
return true;
}
}
@@ -191,6 +197,7 @@ class _IncrementalAnalysisSession implements IncrementalAnalysisSession {
SourceKind kind = context.computeKindOf(source);
if (kind == SourceKind.LIBRARY) {
context.computeResult(source, LINE_INFO);
+ context.computeResult(source, IGNORE_INFO);
context.computeResult(source, INCLUDED_PARTS);
}
}
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698