Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2048693004: Check for registry and extension existence before web_accessible_resources. (Closed)

Created:
4 years, 6 months ago by nasko
Modified:
4 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for registry and extension existence before web_accessible_resources. BUG=618300 Committed: https://crrev.com/7e87b4385d57cecc692ceb8b581ecf95215950fd Cr-Commit-Position: refs/heads/master@{#398627}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M extensions/browser/extension_navigation_throttle.cc View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
nasko
Hey Antony, Can you review this CL for me? It adds a couple of missing ...
4 years, 6 months ago (2016-06-08 18:01:31 UTC) #2
asargent_no_longer_on_chrome
lgtm https://codereview.chromium.org/2048693004/diff/1/extensions/browser/extension_navigation_throttle.cc File extensions/browser/extension_navigation_throttle.cc (right): https://codereview.chromium.org/2048693004/diff/1/extensions/browser/extension_navigation_throttle.cc#newcode82 extensions/browser/extension_navigation_throttle.cc:82: return content::NavigationThrottle::BLOCK_REQUEST; Off the top of my head ...
4 years, 6 months ago (2016-06-08 18:30:13 UTC) #3
asargent_no_longer_on_chrome
> Anyhow, it problem doesn't hurt to have the check here. Ooops, I meant "...it ...
4 years, 6 months ago (2016-06-08 18:30:56 UTC) #4
nasko
On 2016/06/08 18:30:56, Antony Sargent wrote: > > Anyhow, it problem doesn't hurt to have ...
4 years, 6 months ago (2016-06-08 18:34:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048693004/1
4 years, 6 months ago (2016-06-08 18:34:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 18:40:52 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 18:42:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e87b4385d57cecc692ceb8b581ecf95215950fd
Cr-Commit-Position: refs/heads/master@{#398627}

Powered by Google App Engine
This is Rietveld 408576698