Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: ui/events/latency_info.h

Issue 2048673002: Revert of Replace ui::LatencyInfo::InputCoordinate with gfx::PointF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/ipc/latency_info_param_traits_unittest.cc ('k') | ui/events/latency_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/latency_info.h
diff --git a/ui/events/latency_info.h b/ui/events/latency_info.h
index 7f99683eca0f671e42ecc163ee48ee9386355266..97508a8fe44f727cf9b9a1de32e33d215052b877 100644
--- a/ui/events/latency_info.h
+++ b/ui/events/latency_info.h
@@ -16,7 +16,6 @@
#include "base/time/time.h"
#include "base/trace_event/trace_event.h"
#include "ui/events/events_base_export.h"
-#include "ui/gfx/geometry/point_f.h"
#if !defined(OS_IOS)
#include "ipc/ipc_param_traits.h" // nogncheck
@@ -126,6 +125,14 @@
uint32_t event_count;
};
+ struct EVENTS_BASE_EXPORT InputCoordinate {
+ InputCoordinate();
+ InputCoordinate(float x, float y);
+
+ float x;
+ float y;
+ };
+
// Empirically determined constant based on a typical scroll sequence.
enum { kTypicalMaxComponentsPerLatencyInfo = 10 };
@@ -193,10 +200,12 @@
// Returns true if there is still room for keeping the |input_coordinate|,
// false otherwise.
- bool AddInputCoordinate(const gfx::PointF& input_coordinate);
+ bool AddInputCoordinate(const InputCoordinate& input_coordinate);
uint32_t input_coordinates_size() const { return input_coordinates_size_; }
- const gfx::PointF* input_coordinates() const { return input_coordinates_; }
+ const InputCoordinate* input_coordinates() const {
+ return input_coordinates_;
+ }
const LatencyMap& latency_components() const { return latency_components_; }
@@ -227,7 +236,7 @@
// These coordinates represent window coordinates of the original input event.
uint32_t input_coordinates_size_;
- gfx::PointF input_coordinates_[kMaxInputCoordinates];
+ InputCoordinate input_coordinates_[kMaxInputCoordinates];
// The unique id for matching the ASYNC_BEGIN/END trace event.
int64_t trace_id_;
« no previous file with comments | « ui/events/ipc/latency_info_param_traits_unittest.cc ('k') | ui/events/latency_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698