Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2048633004: Remove type converters for ui::Event. (Closed)

Created:
4 years, 6 months ago by Hadi
Modified:
4 years, 6 months ago
Reviewers:
sadrul, sky, no sievers
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, qsr+mojo_chromium.org, tdresser+watch_chromium.org, tfarina, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove type converters for ui::Event. We are using struct traits for serializing/deserializing ui::Event and don't need type converters anymore. BUG=578206 Committed: https://crrev.com/74b54c510611ebaa8479d004a6878abe96e372d3 Cr-Commit-Position: refs/heads/master@{#398655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -616 lines) Patch
M ash/mus/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/mus/frame/non_client_frame_view_mash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/window_manager_application.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/sysui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_tree_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_private.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/mus/ws/event_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/event_matcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/mus/ws/platform_display.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/mus/ws/window_server.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/mojo/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/events/mojo/input_events_type_converters.h View 1 chunk +0 lines, -49 lines 0 comments Download
D ui/events/mojo/input_events_type_converters.cc View 1 chunk +0 lines, -420 lines 0 comments Download
D ui/events/mojo/mojo_extended_key_event_data.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/events/mojo/mojo_extended_key_event_data.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/events/mojo/mojo_input_events_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Hadi
PTAL.
4 years, 6 months ago (2016-06-08 16:02:47 UTC) #2
sadrul
lgtm
4 years, 6 months ago (2016-06-08 17:03:55 UTC) #3
Hadi
sky@ can you please review components/* and ash/*? sievers@ can you please review content/*?
4 years, 6 months ago (2016-06-08 17:46:33 UTC) #5
no sievers
On 2016/06/08 17:46:33, Hadi wrote: > sky@ can you please review components/* and ash/*? > ...
4 years, 6 months ago (2016-06-08 19:09:16 UTC) #6
sky
LGTM
4 years, 6 months ago (2016-06-08 20:13:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048633004/1
4 years, 6 months ago (2016-06-08 20:14:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 20:20:54 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 20:23:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74b54c510611ebaa8479d004a6878abe96e372d3
Cr-Commit-Position: refs/heads/master@{#398655}

Powered by Google App Engine
This is Rietveld 408576698