Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2048633002: Site Settings Desktop: Fix NOTREACHED when group name is unregistered. (Closed)

Created:
4 years, 6 months ago by Finnur
Modified:
4 years, 6 months ago
Reviewers:
tommycli, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: Fix NOTREACHED when group name is unregistered. BUG=617724 Committed: https://crrev.com/3e7d918eb1ac8c7e51cfe51c3a2039d4bb09914d Cr-Commit-Position: refs/heads/master@{#398322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/ui/webui/settings/site_settings_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/site_settings_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/site_settings_helper.cc View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Finnur
4 years, 6 months ago (2016-06-07 11:14:21 UTC) #2
tommycli
lgtm
4 years, 6 months ago (2016-06-07 16:15:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048633002/1
4 years, 6 months ago (2016-06-07 16:47:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/196344)
4 years, 6 months ago (2016-06-07 16:54:21 UTC) #7
michaelpg
lgtm
4 years, 6 months ago (2016-06-07 17:05:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048633002/1
4 years, 6 months ago (2016-06-07 17:06:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 17:37:33 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 17:38:38 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3e7d918eb1ac8c7e51cfe51c3a2039d4bb09914d
Cr-Commit-Position: refs/heads/master@{#398322}

Powered by Google App Engine
This is Rietveld 408576698