Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2048623002:
[Skia] Add support for both CPU and GPU nanobench runs (Closed)
Description[Skia] Add support for both CPU and GPU nanobench runs
BUG=skia:5398
# For minor change to ct_skps.isolate
TBR=maruel
NOTRY=true
Committed: https://crrev.com/47023d2839c7cb6cc0f7a2ef9a10b4f49ce78225
Cr-Commit-Position: refs/heads/master@{#398280}
Patch Set 1 : Initial upload #Patch Set 2 : minor #
Total comments: 2
Messages
Total messages: 27 (13 generated)
rmistry@google.com changed reviewers: + borenet@google.com
LGTM
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048623002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2016/06/07 11:49:02, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. LGTM
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048623002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
rmistry@google.com changed reviewers: + maruel@chromium.org
Description was changed from ========== [Skia] Add support for both CPU and GPU nanobench runs BUG=skia:5398 ========== to ========== [Skia] Add support for both CPU and GPU nanobench runs BUG=skia:5398 # For minor change to ct_skps.isolate TBR=maruel ==========
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048623002/20001
The CQ bit was unchecked by rmistry@google.com
Description was changed from ========== [Skia] Add support for both CPU and GPU nanobench runs BUG=skia:5398 # For minor change to ct_skps.isolate TBR=maruel ========== to ========== [Skia] Add support for both CPU and GPU nanobench runs BUG=skia:5398 # For minor change to ct_skps.isolate TBR=maruel NOTRY=true ==========
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048623002/20001
Message was sent while issue was closed.
Description was changed from ========== [Skia] Add support for both CPU and GPU nanobench runs BUG=skia:5398 # For minor change to ct_skps.isolate TBR=maruel NOTRY=true ========== to ========== [Skia] Add support for both CPU and GPU nanobench runs BUG=skia:5398 # For minor change to ct_skps.isolate TBR=maruel NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Skia] Add support for both CPU and GPU nanobench runs BUG=skia:5398 # For minor change to ct_skps.isolate TBR=maruel NOTRY=true ========== to ========== [Skia] Add support for both CPU and GPU nanobench runs BUG=skia:5398 # For minor change to ct_skps.isolate TBR=maruel NOTRY=true Committed: https://crrev.com/47023d2839c7cb6cc0f7a2ef9a10b4f49ce78225 Cr-Commit-Position: refs/heads/master@{#398280} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/47023d2839c7cb6cc0f7a2ef9a10b4f49ce78225 Cr-Commit-Position: refs/heads/master@{#398280}
Message was sent while issue was closed.
lgtm https://codereview.chromium.org/2048623002/diff/20001/content/test/ct/run_ct_... File content/test/ct/run_ct_skps.py (right): https://codereview.chromium.org/2048623002/diff/20001/content/test/ct/run_ct_... content/test/ct/run_ct_skps.py:36: parser.add_argument('-b', '--builder', required=True, I guess you are fine with this change not being backward compatible.
Message was sent while issue was closed.
https://codereview.chromium.org/2048623002/diff/20001/content/test/ct/run_ct_... File content/test/ct/run_ct_skps.py (right): https://codereview.chromium.org/2048623002/diff/20001/content/test/ct/run_ct_... content/test/ct/run_ct_skps.py:36: parser.add_argument('-b', '--builder', required=True, On 2016/06/07 12:51:31, M-A Ruel wrote: > I guess you are fine with this change not being backward compatible. Yes, landed the corresponding recipe change shortly afterwards in https://codereview.chromium.org/2039213003/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
