Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2048613002: Upstream the grammer for union types to idl_parser (Closed)

Created:
4 years, 6 months ago by bashi
Modified:
4 years, 6 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream the grammer for union types to idl_parser There is no reason to put it in blink_idl_parser.py BUG=617899 Committed: https://crrev.com/993ba2de09730a067a60b963b4b04652784b51d7 Cr-Commit-Position: refs/heads/master@{#398297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py View 1 chunk +0 lines, -27 lines 0 comments Download
M tools/idl_parser/idl_parser.py View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/idl_parser/test_parser/interface_web.idl View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048613002/1
4 years, 6 months ago (2016-06-07 09:43:20 UTC) #2
bashi
PTAL?
4 years, 6 months ago (2016-06-07 09:50:51 UTC) #4
haraken
LGTM
4 years, 6 months ago (2016-06-07 10:42:35 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/240150)
4 years, 6 months ago (2016-06-07 11:18:32 UTC) #7
Yuki
lgtm
4 years, 6 months ago (2016-06-07 12:39:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048613002/1
4 years, 6 months ago (2016-06-07 12:57:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 14:34:06 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 14:35:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/993ba2de09730a067a60b963b4b04652784b51d7
Cr-Commit-Position: refs/heads/master@{#398297}

Powered by Google App Engine
This is Rietveld 408576698