Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2048593004: [tools] Fix detect-builtins.js (Closed)

Created:
4 years, 6 months ago by Jakob Kummerow
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Fix detect-builtins.js - include non-default prototypes (useful for TypedArrays) - print value of string/number properties (avoids endless recursion) Committed: https://crrev.com/bf5f2b5998a1d37f82e29784228ab41432636377 Cr-Commit-Position: refs/heads/master@{#36849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M tools/detect-builtins.js View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL.
4 years, 6 months ago (2016-06-09 09:44:05 UTC) #2
Yang
lgtm
4 years, 6 months ago (2016-06-09 09:50:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048593004/1
4 years, 6 months ago (2016-06-09 09:51:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 10:16:38 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 10:17:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf5f2b5998a1d37f82e29784228ab41432636377
Cr-Commit-Position: refs/heads/master@{#36849}

Powered by Google App Engine
This is Rietveld 408576698