Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2048563004: Set text anti-aliasing settings at PPAPI plugin process on Windows. (Closed)

Created:
4 years, 6 months ago by msr.i386
Modified:
4 years, 6 months ago
Reviewers:
eae, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set text anti-aliasing settings at PPAPI plugin process on Windows. This patch will enable text anti-aliasing to call the following methods: * blink::WebFontRendering::setAntialiasedTextEnabled * blink::WebFontRendering::setLCDTextEnabled This patch will also get anti-aliasing settings from gfx::GetFontRenderParams method. BUG=615375 TEST=If [Smooth edges of screen fonts] at advanced system settings is enabled, text in flash is anti-aliased. If disabled, text is aliased. Committed: https://crrev.com/90d6c375486700b6965665189853549c96716efa Cr-Commit-Position: refs/heads/master@{#399073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
msr.i386
This is my first patch for chromium. Could you review this patch?
4 years, 6 months ago (2016-06-08 02:47:42 UTC) #3
eae
Non-owner LGTM. The right values are passed to blink. Verified CLA.
4 years, 6 months ago (2016-06-09 06:55:36 UTC) #4
msr.i386
piman@chromium.org: Could I get an OWNER review?
4 years, 6 months ago (2016-06-09 07:14:39 UTC) #6
piman
lgtm
4 years, 6 months ago (2016-06-09 19:07:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048563004/1
4 years, 6 months ago (2016-06-09 23:27:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_gn_rel on ...
4 years, 6 months ago (2016-06-10 01:29:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048563004/1
4 years, 6 months ago (2016-06-10 02:04:57 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 03:29:53 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 03:30:04 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 03:31:52 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90d6c375486700b6965665189853549c96716efa
Cr-Commit-Position: refs/heads/master@{#399073}

Powered by Google App Engine
This is Rietveld 408576698