MD History: Enable by default

MD History: Enable by default

This enables the Material Design chrome://history page by default.

BUG=619612
Committed: https://crrev.com/ef4746aba28c07fec8af62b621f4602abd5a64fb
Cr-Commit-Position: refs/heads/master@{#400341}

[tsergeant, 2016-06-14 07:21:54]

Patchset #2 (id:20001) has been deleted

[tsergeant, 2016-06-14 07:22:01]

Patchset #2 (id:40001) has been deleted

[tsergeant, 2016-06-14 07:22:08]

Patchset #2 (id:60001) has been deleted

[tsergeant, 2016-06-14 07:22:39]

tsergeant@chromium.org changed reviewers:
+ thestig@chromium.org

[tsergeant, 2016-06-14 07:22:40]

+thestig@, PTAL

[tsergeant, 2016-06-14 07:22:52]

Description was changed from

==========
MD History: Enable by default

This enables the Material Design chrome://history page by default.

BUG=425625
==========

to

==========
MD History: Enable by default

This enables the Material Design chrome://history page by default.

BUG=425625
==========

[tsergeant, 2016-06-14 07:34:24]

Description was changed from

==========
MD History: Enable by default

This enables the Material Design chrome://history page by default.

BUG=425625
==========

to

==========
MD History: Enable by default

This enables the Material Design chrome://history page by default.

BUG=619612
==========

[Dan Beam, 2016-06-14 21:24:26]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-06-14 21:24:27]

https://codereview.chromium.org/2048553002/diff/80001/chrome/browser/history/...
File chrome/browser/history/history_browsertest.cc (right):

https://codereview.chromium.org/2048553002/diff/80001/chrome/browser/history/...
chrome/browser/history/history_browsertest.cc:304:
base::FeatureList::SetInstance(std::move(feature_list));
can you make this a utility method?

[tsergeant, 2016-06-14 23:58:02]

https://codereview.chromium.org/2048553002/diff/80001/chrome/browser/history/...
File chrome/browser/history/history_browsertest.cc (right):

https://codereview.chromium.org/2048553002/diff/80001/chrome/browser/history/...
chrome/browser/history/history_browsertest.cc:304:
base::FeatureList::SetInstance(std::move(feature_list));
On 2016/06/14 21:24:27, Dan Beam wrote:
> can you make this a utility method?

Do you mean something like MDHistoryUI::DisableForTesting() to be used across
all of these tests?

[Dan Beam, 2016-06-14 23:59:52]

https://codereview.chromium.org/2048553002/diff/80001/chrome/browser/history/...
File chrome/browser/history/history_browsertest.cc (right):

https://codereview.chromium.org/2048553002/diff/80001/chrome/browser/history/...
chrome/browser/history/history_browsertest.cc:304:
base::FeatureList::SetInstance(std::move(feature_list));
On 2016/06/14 23:58:02, tsergeant wrote:
> On 2016/06/14 21:24:27, Dan Beam wrote:
> > can you make this a utility method?
> 
> Do you mean something like MDHistoryUI::DisableForTesting() to be used across
> all of these tests?

yes

[tsergeant, 2016-06-15 01:57:29]

https://codereview.chromium.org/2048553002/diff/80001/chrome/browser/history/...
File chrome/browser/history/history_browsertest.cc (right):

https://codereview.chromium.org/2048553002/diff/80001/chrome/browser/history/...
chrome/browser/history/history_browsertest.cc:304:
base::FeatureList::SetInstance(std::move(feature_list));
On 2016/06/14 23:59:52, Dan Beam wrote:
> On 2016/06/14 23:58:02, tsergeant wrote:
> > On 2016/06/14 21:24:27, Dan Beam wrote:
> > > can you make this a utility method?
> > 
> > Do you mean something like MDHistoryUI::DisableForTesting() to be used
across
> > all of these tests?
> 
> yes

Done.

[Dan Beam, 2016-06-15 02:01:56]

lgtm

https://codereview.chromium.org/2048553002/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/md_history_ui.cc (right):

https://codereview.chromium.org/2048553002/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/md_history_ui.cc:144: //static
nit: // static

[tsergeant, 2016-06-15 02:39:44]

https://codereview.chromium.org/2048553002/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/md_history_ui.cc (right):

https://codereview.chromium.org/2048553002/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/md_history_ui.cc:144: //static
On 2016/06/15 02:01:56, Dan Beam wrote:
> nit: // static

Oops, done.

[Lei Zhang, 2016-06-16 23:20:31]

lgtm

[tsergeant, 2016-06-16 23:30:58]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-06-16 23:30:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2048553002/#ps120001
(title: "Fix comment")

[commit-bot: I haz the power, 2016-06-16 23:34:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048553002/120001

[commit-bot: I haz the power, 2016-06-16 23:48:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 23:48:27]

Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[tsergeant, 2016-06-17 00:08:38]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-06-17 00:09:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048553002/120001

[commit-bot: I haz the power, 2016-06-17 00:27:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 00:27:15]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[tsergeant, 2016-06-17 03:12:24]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-06-17 03:12:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048553002/120001

[commit-bot: I haz the power, 2016-06-17 03:30:32]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-06-17 03:31:53]

Description was changed from

==========
MD History: Enable by default

This enables the Material Design chrome://history page by default.

BUG=619612
==========

to

==========
MD History: Enable by default

This enables the Material Design chrome://history page by default.

BUG=619612

Committed: https://crrev.com/ef4746aba28c07fec8af62b621f4602abd5a64fb
Cr-Commit-Position: refs/heads/master@{#400341}
==========

[commit-bot: I haz the power, 2016-06-17 03:31:54]

Patchset 4 (id:??) landed as
https://crrev.com/ef4746aba28c07fec8af62b621f4602abd5a64fb
Cr-Commit-Position: refs/heads/master@{#400341}