Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2048543002: [turbofan] Only run TypeHintAnalysis when --turbo-type-feedback is on. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Only run TypeHintAnalysis when --turbo-type-feedback is on. There's no point in trying to extract the type hints from the fullcodegen CompareICs, BinaryOpICs and ToBooleanICs if the feedback is not consumed (which is guarded by the flag). R=jarin@chromium.org Committed: https://crrev.com/dad8ed5342cb6e8c2ffc2fdb4d2db74d71128853 Cr-Commit-Position: refs/heads/master@{#36768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/pipeline.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-07 04:05:23 UTC) #1
Benedikt Meurer
Hey Jaro, Simple refactoring for the pipeline. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-07 04:06:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048543002/1
4 years, 6 months ago (2016-06-07 04:15:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 04:31:17 UTC) #6
Yang
lgtm
4 years, 6 months ago (2016-06-07 04:33:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048543002/1
4 years, 6 months ago (2016-06-07 04:33:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 04:35:33 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 04:37:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dad8ed5342cb6e8c2ffc2fdb4d2db74d71128853
Cr-Commit-Position: refs/heads/master@{#36768}

Powered by Google App Engine
This is Rietveld 408576698