third_party/widevine/cdm/widevine_cdm_common.h - Issue 2048523002: Fix base::GetNativeLibraryName() for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/widevine/cdm/widevine_cdm_common.h

Issue 2048523002: Fix base::GetNativeLibraryName() for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_lib_clean

Patch Set: rebase correctly, update comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/widevine/cdm/widevine_cdm_common.h

diff --git a/third_party/widevine/cdm/widevine_cdm_common.h b/third_party/widevine/cdm/widevine_cdm_common.h

index 0dafb1e2b26abce7cdef8988e0ce429e05f8361f..f0a256325c9d6c876262ff48a3fd9e4830fcc327 100644

--- a/third_party/widevine/cdm/widevine_cdm_common.h

+++ b/third_party/widevine/cdm/widevine_cdm_common.h

@@ -34,14 +34,7 @@ const char kWidevineCdmPluginMimeTypeDescription[] =

"Widevine Content Decryption Module";

// File name of the CDM on different platforms.

Mark Mentovai 2016/06/10 23:39:59 Not a filename. Not on different platforms.

Lei Zhang 2016/06/13 19:10:07 Done.

-const char kWidevineCdmFileName[] =

-#if defined(OS_MACOSX)

- "libwidevinecdm.dylib";

-#elif defined(OS_WIN)

- "widevinecdm.dll";

-#else // OS_LINUX, etc.

- "libwidevinecdm.so";

-#endif

+const char kWidevineCdmName[] = "widevinecdm";

Mark Mentovai 2016/06/10 23:39:59 Maybe kWidevineCdmLibraryName is better.

Mark Mentovai 2016/06/10 23:39:59 The definitions are right here in the .h?

Lei Zhang 2016/06/13 19:10:07 Done.

Lei Zhang 2016/06/13 19:10:07 There's no .cc file. *innocent look*

// File name of the adapter on different platforms.

const char kWidevineCdmAdapterFileName[] =

« media/cdm/external_clear_key_test_helper.cc ('K') | « net/udp/udp_socket_posix.cc ('k') | no next file » | no next file with comments »