Fix base::GetNativeLibraryName() for Mac.

chrome/browser/load_library_perf_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
+#include "base/native_library.h"
 #include "base/path_service.h"
 #include "base/scoped_native_library.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/perf/perf_test.h"
 
 #include "widevine_cdm_version.h"  //  In SHARED_INTERMEDIATE_DIR.
 
@@ skipping 34 matching lines @@
   perf_test::PrintResult("time_to_load_library",
                          "",
                          library_name.AsUTF8Unsafe(),
                          delta,
                          "ms",
                          true);
 }
 
 #if defined(ENABLE_PEPPER_CDMS)
 
 // File name of the ClearKey CDM on different platforms.

[Mark Mentovai, 2016/06/10 23:39:59]

Not a filename. “Different platforms” is extraneous now.

[Lei Zhang, 2016/06/13 19:10:07]

Done.

 // TODO(xhwang): Consolidate this with external_clear_key_test_helper.cc.
-const char kClearKeyCdmFileName[] =
-#if defined(OS_MACOSX)
-    "libclearkeycdm.dylib";
-#elif defined(OS_WIN)
-    "clearkeycdm.dll";
-#else  // OS_LINUX, etc.
-    "libclearkeycdm.so";
-#endif
+const char kClearKeyCdmName[] = "clearkeycdm";

[Mark Mentovai, 2016/06/10 23:39:59]

Maybe kClearKeyCdmLibraryName. But I see no reason for this to be a const char[]
out here. Just write it in-line in LoadCDMPerfTest.ExternalClearKey, either as a
const down there, or just a literal as the function call argument.

[Lei Zhang, 2016/06/13 19:10:06]

I renamed the variable, and merged it with the copy in media/

 
 void MeasureSizeAndTimeToLoadCdm(const std::string& cdm_base_dir,
                                  const std::string& cdm_name) {
   MeasureSizeAndTimeToLoadNativeLibrary(
       media::GetPlatformSpecificDirectory(cdm_base_dir),
       base::FilePath::FromUTF8Unsafe(cdm_name));
 }
 
 #endif  // defined(ENABLE_PEPPER_CDMS)
 
 }  // namespace
 
 #if defined(ENABLE_PEPPER_CDMS)
 #if defined(WIDEVINE_CDM_AVAILABLE)
 TEST(LoadCDMPerfTest, Widevine) {
-  MeasureSizeAndTimeToLoadCdm(kWidevineCdmBaseDirectory, kWidevineCdmFileName);
+  MeasureSizeAndTimeToLoadCdm(kWidevineCdmBaseDirectory,
+                              base::GetNativeLibraryName(kWidevineCdmName));
 }
 
 TEST(LoadCDMPerfTest, WidevineAdapter) {
   MeasureSizeAndTimeToLoadCdm(kWidevineCdmBaseDirectory,
                               kWidevineCdmAdapterFileName);
 }
 #endif  // defined(WIDEVINE_CDM_AVAILABLE)
 
 TEST(LoadCDMPerfTest, ExternalClearKey) {
-  MeasureSizeAndTimeToLoadCdm(kClearKeyCdmBaseDirectory, kClearKeyCdmFileName);
+  MeasureSizeAndTimeToLoadCdm(kClearKeyCdmBaseDirectory,
+                              base::GetNativeLibraryName(kClearKeyCdmName));
 }
 
 TEST(LoadCDMPerfTest, ExternalClearKeyAdapter) {
   MeasureSizeAndTimeToLoadCdm(kClearKeyCdmBaseDirectory,
                               kClearKeyCdmAdapterFileName);
 }
 #endif  // defined(ENABLE_PEPPER_CDMS)