Chromium Code Reviews| Index: components/visitedlink/browser/visitedlink_event_listener.h |
| diff --git a/components/visitedlink/browser/visitedlink_event_listener.h b/components/visitedlink/browser/visitedlink_event_listener.h |
| index 7439471bdefdb0db3ea62be74e8fd5831e6b5b95..cbd2859587ed72afb878491bf469656336d9f949 100644 |
| --- a/components/visitedlink/browser/visitedlink_event_listener.h |
| +++ b/components/visitedlink/browser/visitedlink_event_listener.h |
| @@ -6,18 +6,14 @@ |
| #define COMPONENTS_VISITEDLINK_BROWSER_VISITEDLINK_EVENT_LISTENER_H_ |
| #include <map> |
| +#include <memory> |
| #include "base/macros.h" |
| -#include "base/memory/linked_ptr.h" |
| #include "base/timer/timer.h" |
| #include "components/visitedlink/browser/visitedlink_master.h" |
| #include "content/public/browser/notification_observer.h" |
| #include "content/public/browser/notification_registrar.h" |
| -namespace base { |
| -class SharedMemory; |
| -} |
| - |
| namespace content { |
| class BrowserContext; |
| } |
| @@ -32,11 +28,11 @@ class VisitedLinkUpdater; |
| class VisitedLinkEventListener : public VisitedLinkMaster::Listener, |
| public content::NotificationObserver { |
| public: |
| - VisitedLinkEventListener(VisitedLinkMaster* master, |
| - content::BrowserContext* browser_context); |
| + VisitedLinkEventListener(content::BrowserContext* browser_context, |
| + base::Timer* coalesce_timer_override); |
|
brettw
2016/09/15 22:33:08
Above here we should document coalesce_timer_overr
Sam McNally
2016/09/19 00:28:18
Done.
|
| ~VisitedLinkEventListener() override; |
| - void NewTable(base::SharedMemory* table_memory) override; |
| + void NewTable(mojo::SharedBufferHandle table) override; |
| void Add(VisitedLinkMaster::Fingerprint fingerprint) override; |
| void Reset(bool invalidate_hashes) override; |
| @@ -48,16 +44,17 @@ class VisitedLinkEventListener : public VisitedLinkMaster::Listener, |
| const content::NotificationSource& source, |
| const content::NotificationDetails& details) override; |
| - base::OneShotTimer coalesce_timer_; |
| + base::OneShotTimer coalesce_timer_owner_; |
|
brettw
2016/09/15 22:33:08
Can you put a comment here on this, especially the
Sam McNally
2016/09/19 00:28:18
Done.
|
| + base::Timer* coalesce_timer_; |
| VisitedLinkCommon::Fingerprints pending_visited_links_; |
| content::NotificationRegistrar registrar_; |
| // Map between renderer child ids and their VisitedLinkUpdater. |
| - typedef std::map<int, linked_ptr<VisitedLinkUpdater> > Updaters; |
| + typedef std::map<int, std::unique_ptr<VisitedLinkUpdater>> Updaters; |
| Updaters updaters_; |
| - VisitedLinkMaster* master_; |
| + mojo::ScopedSharedBufferHandle shared_memory_; |
| // Used to filter RENDERER_PROCESS_CREATED notifications to renderers that |
| // belong to this BrowserContext. |