Convert visitedlink to use mojo.

android_webview/renderer/aw_content_renderer_client.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/renderer/aw_content_renderer_client.h"
 
 #include <vector>
 
 #include "android_webview/common/aw_resource.h"
 #include "android_webview/common/aw_switches.h"
@@ skipping 22 matching lines @@
 #include "components/web_restrictions/interfaces/web_restrictions.mojom.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/renderer/document_state.h"
 #include "content/public/renderer/navigation_state.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "net/base/escape.h"
 #include "net/base/net_errors.h"
 #include "services/shell/public/cpp/interface_provider.h"
+#include "services/shell/public/cpp/interface_registry.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebURL.h"
 #include "third_party/WebKit/public/platform/WebURLError.h"
 #include "third_party/WebKit/public/platform/WebURLRequest.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebNavigationType.h"
 #include "third_party/WebKit/public/web/WebSecurityPolicy.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "url/gurl.h"
@@ skipping 11 matching lines @@
 AwContentRendererClient::AwContentRendererClient() {}
 
 AwContentRendererClient::~AwContentRendererClient() {}
 
 void AwContentRendererClient::RenderThreadStarted() {
   RenderThread* thread = RenderThread::Get();
   aw_render_thread_observer_.reset(new AwRenderThreadObserver);
   thread->AddObserver(aw_render_thread_observer_.get());
 
   visited_link_slave_.reset(new visitedlink::VisitedLinkSlave);
-  thread->AddObserver(visited_link_slave_.get());
+  thread->GetInterfaceRegistry()->AddInterface(
+      base::Bind(&visitedlink::VisitedLinkSlave::Bind,
+                 base::Unretained(visited_link_slave_.get())));

[dcheng, 2016/09/20 22:29:27]

I am still uncomfortable that Mojo is encouraging wide use of base::Unretained()
in situations like this. In RenderThread or RenderFrame, it's somewhat easy to
verify that lifetimes are correct. But once impls start living in things that
aren't as tightly coupled, then the picture becomes significantly less clear: is
it possible for the InterfaceRegistry to outlive |this|?

We had several use-after-frees bugs last year due to base::Unretained() use that
"should have been safe" but weren't. Is there any possibility to just default to
refcounting impls that are reused? Alternatively, even using a WeakPtr would be
better. What would be the downside?

[Sam McNally, 2016/09/21 02:38:14]

Done.

 
   blink::WebString content_scheme(base::ASCIIToUTF16(url::kContentScheme));
   blink::WebSecurityPolicy::registerURLSchemeAsLocal(content_scheme);
 
   blink::WebString aw_scheme(
       base::ASCIIToUTF16(android_webview::kAndroidWebViewVideoPosterScheme));
   blink::WebSecurityPolicy::registerURLSchemeAsSecure(aw_scheme);
 
 #if defined(ENABLE_SPELLCHECK)
   if (!spellcheck_) {
@@ skipping 191 matching lines @@
   for (auto* extension : kMediaPlayerExtensions) {
     if (base::EndsWith(url.path(), extension,
                        base::CompareCase::INSENSITIVE_ASCII)) {
       return true;
     }
   }
   return false;
 }
 
 }  // namespace android_webview