Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2048463002: enable compatiblity with 1.18 SDKs (Closed)

Created:
4 years, 6 months ago by Jennifer Messerly
Modified:
4 years, 6 months ago
Reviewers:
Leaf, srawlins
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

enable compatiblity with 1.18 SDKs fixes #584, works around analyzer message #583 R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/6c6cb854f0a0075a774056e19433a388bcad217c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M lib/src/compiler/code_generator.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pubspec.lock View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jennifer Messerly
4 years, 6 months ago (2016-06-06 23:36:27 UTC) #2
Jennifer Messerly
4 years, 6 months ago (2016-06-07 00:28:21 UTC) #4
Leaf
lgtm
4 years, 6 months ago (2016-06-07 00:28:25 UTC) #6
Jennifer Messerly
4 years, 6 months ago (2016-06-07 00:29:10 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6c6cb854f0a0075a774056e19433a388bcad217c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698