Source/core/rendering/LayoutRepainter.h - Issue 204843002: Reduce invalidation on children-needs-layout containers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/LayoutRepainter.h

Issue 204843002: Reduce invalidation on children-needs-layout containers (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated after Levi's review. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/platform/win/fast/repaint/stacked-diacritics-expected.txt ('k') | Source/core/rendering/LayoutRepainter.cpp » ('j') | Source/core/rendering/LayoutRepainter.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)

3 * (C) 2000 Antti Koivisto (koivisto@kde.org)	3 * (C) 2000 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)	5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)

6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.	6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.

7 * Copyright (C) 2009 Google Inc. All rights reserved.	7 * Copyright (C) 2009 Google Inc. All rights reserved.

8 *	8 *

9 * This library is free software; you can redistribute it and/or	9 * This library is free software; you can redistribute it and/or

10 * modify it under the terms of the GNU Library General Public	10 * modify it under the terms of the GNU Library General Public

(...skipping 25 matching lines...) Expand all Loading...
36 class LayoutRepainter {	36 class LayoutRepainter {

37 public:	37 public:

38 LayoutRepainter(RenderObject&, bool checkForRepaint);	38 LayoutRepainter(RenderObject&, bool checkForRepaint);

39	39

40 bool checkForRepaint() const { return m_checkForRepaint; }	40 bool checkForRepaint() const { return m_checkForRepaint; }

41	41

42 // Return true if it repainted.	42 // Return true if it repainted.

43 bool repaintAfterLayout();	43 bool repaintAfterLayout();

44	44

45 private:	45 private:

	46 bool skipInvalidationWhenLayingOutChildren() const;

	47

46 RenderObject& m_object;	48 RenderObject& m_object;

47 RenderLayerModelObject* m_repaintContainer;	49 RenderLayerModelObject* m_repaintContainer;

48 // We store these values as LayoutRects, but the final invalidations will be pixel snapped	50 // We store these values as LayoutRects, but the final invalidations will be pixel snapped

49 LayoutRect m_oldBounds;	51 LayoutRect m_oldBounds;

50 LayoutRect m_oldOutlineBox;	52 LayoutRect m_oldOutlineBox;

51 bool m_checkForRepaint;	53 bool m_checkForRepaint;

52 };	54 };

53	55

54 } // namespace WebCore	56 } // namespace WebCore

55	57

56 #endif // LayoutRepainter_h	58 #endif // LayoutRepainter_h

OLD	NEW