Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: Source/core/rendering/RenderBox.cpp

Issue 204843002: Reduce invalidation on children-needs-layout containers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: And more and more... Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 4111 matching lines...) Expand 10 before | Expand all | Expand 10 after
4122 { 4122 {
4123 ASSERT(!needsLayout()); 4123 ASSERT(!needsLayout());
4124 // If fragmentation height has changed, we need to lay out. No need to enter the renderer if it 4124 // If fragmentation height has changed, we need to lay out. No need to enter the renderer if it
4125 // is childless, though. 4125 // is childless, though.
4126 if (view()->layoutState()->pageLogicalHeightChanged() && slowFirstChild()) 4126 if (view()->layoutState()->pageLogicalHeightChanged() && slowFirstChild())
4127 layoutScope.setChildNeedsLayout(this); 4127 layoutScope.setChildNeedsLayout(this);
4128 } 4128 }
4129 4129
4130 void RenderBox::addVisualEffectOverflow() 4130 void RenderBox::addVisualEffectOverflow()
4131 { 4131 {
4132 if (!style()->boxShadow() && !style()->hasBorderImageOutsets() && !style()-> hasOutline()) 4132 if (!style()->hasVisualOverflowingEffect())
4133 return; 4133 return;
4134 4134
4135 LayoutRect borderBox = borderBoxRect(); 4135 LayoutRect borderBox = borderBoxRect();
4136 LayoutUnit overflowMinX = borderBox.x(); 4136 LayoutUnit overflowMinX = borderBox.x();
4137 LayoutUnit overflowMaxX = borderBox.maxX(); 4137 LayoutUnit overflowMaxX = borderBox.maxX();
4138 LayoutUnit overflowMinY = borderBox.y(); 4138 LayoutUnit overflowMinY = borderBox.y();
4139 LayoutUnit overflowMaxY = borderBox.maxY(); 4139 LayoutUnit overflowMaxY = borderBox.maxY();
4140 4140
4141 // Compute box-shadow overflow first. 4141 // Compute box-shadow overflow first.
4142 if (style()->boxShadow()) { 4142 if (style()->boxShadow()) {
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
4667 return 0; 4667 return 0;
4668 4668
4669 if (!layoutState && !flowThreadContainingBlock()) 4669 if (!layoutState && !flowThreadContainingBlock())
4670 return 0; 4670 return 0;
4671 4671
4672 RenderBlock* containerBlock = containingBlock(); 4672 RenderBlock* containerBlock = containingBlock();
4673 return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop(); 4673 return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop();
4674 } 4674 }
4675 4675
4676 } // namespace WebCore 4676 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/platform/linux/svg/custom/use-setAttribute-crash-expected.txt ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698