Reduce invalidation on children-needs-layout containers

Source/core/rendering/RenderTable.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 363 matching lines @@
         caption->layoutIfNeeded();
     }
     // Apply the margins to the location now that they are definitely available from layout
     LayoutUnit captionLogicalTop = collapsedMarginBeforeForChild(caption) + logicalHeight();
     if (view()->layoutState()->isPaginated()) {
         captionLogicalTop += caption->paginationStrut();
         caption->setPaginationStrut(0);
     }
     caption->setLogicalLocation(LayoutPoint(caption->marginStart(), captionLogicalTop));
 
-    if (!selfNeedsLayout() && caption->checkForPaintInvalidationDuringLayout())
-        caption->repaintDuringLayoutIfMoved(captionRect);
+    if (!selfNeedsLayout()) {
+        if (caption->checkForPaintInvalidationDuringLayout())

[dsinclair, 2014/06/25 12:51:16]

This branch can go away as checkForPaintInvalidationDuringLayout would always
return false with RAL enabled.

[Julien - ping for review, 2014/06/30 22:36:30]

done!

+            caption->repaintDuringLayoutIfMoved(captionRect);
+        else
+            caption->setMayNeedPaintInvalidation(true);
+    }
 
     setLogicalHeight(logicalHeight() + caption->logicalHeight() + collapsedMarginBeforeForChild(caption) + collapsedMarginAfterForChild(caption));
 }
 
 void RenderTable::distributeExtraLogicalHeight(int extraLogicalHeight)
 {
     if (extraLogicalHeight <= 0)
         return;
 
     // FIXME: Distribute the extra logical height between all table sections instead of giving it all to the first one.
@@ skipping 141 matching lines @@
 
         // position the table sections
         RenderTableSection* section = topSection();
         while (section) {
             if (!sectionMoved && section->logicalTop() != logicalHeight()) {
                 sectionMoved = true;
                 movedSectionLogicalTop = min(logicalHeight(), section->logicalTop()) + (style()->isHorizontalWritingMode() ? section->visualOverflowRect().y() : section->visualOverflowRect().x());
             }
             section->setLogicalLocation(LayoutPoint(sectionLogicalLeft, logicalHeight()));
 
+            // As we may skip invalidation on the table, we need to ensure that sections are invalidated when they moved.
+            if (sectionMoved && !section->selfNeedsLayout())
+                section->setMayNeedPaintInvalidation(true);
+
             setLogicalHeight(logicalHeight() + section->logicalHeight());
+
             section = sectionBelow(section);
         }
 
         setLogicalHeight(logicalHeight() + borderAndPaddingAfter);
 
         for (unsigned i = 0; i < m_captions.size(); i++) {
             if (m_captions[i]->style()->captionSide() != CAPBOTTOM)
                 continue;
             layoutCaption(m_captions[i]);
         }
@@ skipping 895 matching lines @@
 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCell* cell) const
 {
     ASSERT(cell->isFirstOrLastCellInRow());
     if (hasSameDirectionAs(cell->row()))
         return style()->borderEnd();
 
     return style()->borderStart();
 }
 
 }