Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: Source/core/rendering/LayoutRepainter.cpp

Issue 204843002: Reduce invalidation on children-needs-layout containers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 } 48 }
49 m_oldOutlineBox = m_object.outlineBoundsForRepaint(m_repaintContainer); 49 m_oldOutlineBox = m_object.outlineBoundsForRepaint(m_repaintContainer);
50 } 50 }
51 } 51 }
52 52
53 bool LayoutRepainter::repaintAfterLayout() 53 bool LayoutRepainter::repaintAfterLayout()
54 { 54 {
55 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) 55 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled())
56 return false; 56 return false;
57 57
58 if (!m_object.needsLayoutBecauseOfChildren() && m_object.hasNothingToPaint() )
leviw_travelin_and_unemployed 2014/03/19 17:47:32 Why bother with the hasNothingToPaint bitfield ins
Julien - ping for review 2014/03/20 01:30:33 Very good point, sir! Changed.
59 return false;
60
58 // Hits in compositing/video/video-controls-layer-creation.html 61 // Hits in compositing/video/video-controls-layer-creation.html
59 DisableCompositingQueryAsserts disabler; 62 DisableCompositingQueryAsserts disabler;
60 63
61 return m_checkForRepaint ? m_object.repaintAfterLayoutIfNeeded(m_repaintCont ainer, m_object.selfNeedsLayout(), m_oldBounds, m_oldOutlineBox) : false; 64 return m_checkForRepaint ? m_object.repaintAfterLayoutIfNeeded(m_repaintCont ainer, m_object.selfNeedsLayout(), m_oldBounds, m_oldOutlineBox) : false;
62 } 65 }
63 66
64 } // namespace WebCore 67 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/platform/win/fast/repaint/table-collapsed-border-expected.txt ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698