Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2048393002: Test for bug 618429. (Closed)

Created:
4 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 6 months ago
Reviewers:
whywhat
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test for bug 618429. BUG=618429 R=avayvod@chromium.org Committed: https://crrev.com/1bb90f6b88a2555e3f7cc485bc46e9d61d1d2201 Cr-Commit-Position: refs/heads/master@{#399047}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/media/play-promise-crash.html View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mlamouri (slow - plz ping)
avayvod@, PTAL
4 years, 6 months ago (2016-06-09 14:39:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048393002/1
4 years, 6 months ago (2016-06-09 19:45:32 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-09 19:45:33 UTC) #5
whywhat
lgtm % nits https://codereview.chromium.org/2048393002/diff/1/third_party/WebKit/LayoutTests/media/play-promise-crash.html File third_party/WebKit/LayoutTests/media/play-promise-crash.html (right): https://codereview.chromium.org/2048393002/diff/1/third_party/WebKit/LayoutTests/media/play-promise-crash.html#newcode19 third_party/WebKit/LayoutTests/media/play-promise-crash.html:19: gc(); nit: add a comment of ...
4 years, 6 months ago (2016-06-09 19:48:28 UTC) #6
mlamouri (slow - plz ping)
Comments applied.
4 years, 6 months ago (2016-06-09 21:16:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048393002/20001
4 years, 6 months ago (2016-06-09 21:16:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 23:09:36 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 23:09:38 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 23:11:14 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1bb90f6b88a2555e3f7cc485bc46e9d61d1d2201
Cr-Commit-Position: refs/heads/master@{#399047}

Powered by Google App Engine
This is Rietveld 408576698