chrome/renderer/content_settings_observer.h - Issue 2048303002: Fix broken mixed script Rappor metric and add browser test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/content_settings_observer.h

Issue 2048303002: Fix broken mixed script Rappor metric and add browser test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/renderer/content_settings_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/content_settings_observer.h

diff --git a/chrome/renderer/content_settings_observer.h b/chrome/renderer/content_settings_observer.h

index 27a304cc7a6d87c9525376eeb861d636c7a3a6ae..b3280e6ea243c8ffcd3bd0812c539f39a527cca8 100644

--- a/chrome/renderer/content_settings_observer.h

+++ b/chrome/renderer/content_settings_observer.h

@@ -55,6 +55,10 @@ class ContentSettingsObserver

// Sends an IPC notification that the specified content type was blocked

// with additional metadata.

+ //

+ // When |settings_type| is CONTENT_SETTINGS_TYPE_MIXEDSCRIPT, the

+ // browser process expects |details| to contain a valid GURL

+ // describing the mixed script that was run.

void DidBlockContentType(ContentSettingsType settings_type,

const base::string16& details);

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/renderer/content_settings_observer.cc » ('j') | no next file with comments »