Fix broken mixed script Rappor metric and add browser test

chrome/browser/content_settings/content_settings_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/cookie_settings_factory.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/net/url_request_mock_util.h"
 #include "chrome/browser/plugins/chrome_plugin_service_filter.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/test_launcher_utils.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/content_settings/core/browser/cookie_settings.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
+#include "components/network_session_configurator/switches.h"
+#include "components/rappor/test_rappor_service.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/plugin_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "media/cdm/cdm_paths.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
+#include "net/test/embedded_test_server/request_handler_util.h"
 #include "net/test/url_request/url_request_mock_http_job.h"
 
 #include "widevine_cdm_version.h"  // In SHARED_INTERMEDIATE_DIR.
 
 #if defined(OS_MACOSX)
 #include "base/mac/scoped_nsautorelease_pool.h"
 #endif
 
 #if defined(ENABLE_PEPPER_CDMS)
 #include "chrome/browser/media/pepper_cdm_test_constants.h"
@@ skipping 190 matching lines @@
 
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_EQ(base::UTF8ToUTF16(test_url.spec() + " failed to load"),
             web_contents->GetTitle());
 
   EXPECT_TRUE(TabSpecificContentSettings::FromWebContents(web_contents)->
       IsContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES));
 }
 
+class ContentSettingsIgnoreCertErrorsTest : public ContentSettingsTest {
+ protected:
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    command_line->AppendSwitch(switches::kIgnoreCertificateErrors);
+  }
+};
+
+// Tests that a RAPPOR metric is recorded when mixed script is
+// blocked. Regression test for https://crbug.com/536975.
+//
+// This test fixture sets up the browser to ignore certificate errors,
+// so that a non-matching, non-local hostname can be used for the
+// test. This is because Rappor treats local hostnames as slightly
+// special, so it's a little nicer to test with a non-local hostname.
+IN_PROC_BROWSER_TEST_F(ContentSettingsIgnoreCertErrorsTest,
+                       MixedScriptRapporMetric) {
+  host_resolver()->AddRule("*", "127.0.0.1");
+  ASSERT_TRUE(https_server_.Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
+  std::string replacement_path;
+  base::StringPairs replacement_text;
+  replacement_text.push_back(
+      make_pair("REPLACE_WITH_HOST_AND_PORT",
+                embedded_test_server()->host_port_pair().ToString()));
+  net::test_server::GetFilePathWithReplacements(
+      "/ssl/page_runs_insecure_content.html", replacement_text,
+      &replacement_path);
+  GURL url = https_server_.GetURL(replacement_path);
+
+  // Rappor treats local hostnames a little bit special (e.g. records
+  // "127.0.0.1" as "localhost"), so use a non-local hostname for
+  // convenience.
+  GURL::Replacements replace_host;
+  replace_host.SetHostStr("example.test");
+  url = url.ReplaceComponents(replace_host);
+
+  rappor::TestRapporService rappor_service;
+  TabSpecificContentSettings* tab_specific_content_settings =
+      TabSpecificContentSettings::FromWebContents(
+          browser()->tab_strip_model()->GetWebContentsAt(0));
+  tab_specific_content_settings->SetRapporServiceForTesting(&rappor_service);
+  EXPECT_EQ(0, rappor_service.GetReportsCount());
+
+  ui_test_utils::NavigateToURL(browser(), url);
+
+  EXPECT_EQ(1, rappor_service.GetReportsCount());
+  std::string sample;
+  rappor::RapporType type;
+  EXPECT_TRUE(rappor_service.GetRecordedSampleForMetric(
+      "ContentSettings.MixedScript.DisplayedShield", &sample, &type));
+  EXPECT_EQ(url.host(), sample);
+  EXPECT_EQ(rappor::ETLD_PLUS_ONE_RAPPOR_TYPE, type);
+}
+
 // TODO(jww): This should be removed after strict secure cookies is enabled for
 // all and this test should be moved into ContentSettingsTest above.
 class ContentSettingsStrictSecureCookiesBrowserTest
     : public ContentSettingsTest {
  protected:
   void SetUpCommandLine(base::CommandLine* cmd) override {
     cmd->AppendSwitch(switches::kEnableExperimentalWebPlatformFeatures);
   }
 };
 
@@ skipping 257 matching lines @@
 #endif  // defined(ENABLE_PEPPER_CDMS)
 
 #if !defined(DISABLE_NACL)
 IN_PROC_BROWSER_TEST_F(PepperContentSettingsSpecialCasesJavaScriptBlockedTest,
                        NaCl) {
   RunJavaScriptBlockedTest("load_nacl_no_js.html", true);
 }
 #endif  // !defined(DISABLE_NACL)
 
 #endif  // defined(ENABLE_PLUGINS)