Fix broken mixed script Rappor metric and add browser test

chrome/renderer/content_settings_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/content_settings_observer.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "components/content_settings/content/common/content_settings_messages.h"
 #include "content/public/common/url_constants.h"
@@ skipping 465 matching lines @@
                      base::CompareCase::INSENSITIVE_ASCII))
     SendInsecureContentSignal(INSECURE_CONTENT_RUN_JS);
   else if (base::EndsWith(resource_gurl.path(), kDotCSS,
                           base::CompareCase::INSENSITIVE_ASCII))
     SendInsecureContentSignal(INSECURE_CONTENT_RUN_CSS);
   else if (base::EndsWith(resource_gurl.path(), kDotSWF,
                           base::CompareCase::INSENSITIVE_ASCII))
     SendInsecureContentSignal(INSECURE_CONTENT_RUN_SWF);
 
   if (!allow_running_insecure_content_ && !allowed_per_settings) {
-    DidBlockContentType(CONTENT_SETTINGS_TYPE_MIXEDSCRIPT, origin.host());
+    DidBlockContentType(CONTENT_SETTINGS_TYPE_MIXEDSCRIPT, origin.toString());

[sky, 2016/06/16 16:22:47]

I'm not familiar with this code, so why is toString better than host? A comment
would help. What is the expectation for the argument supplied to
DidBlockContentType? A comment in the header would be helpful.

[estark, 2016/06/16 16:56:58]

The browser-side IPC handler expects |details| to be a valid GURL for this
content type (and a hostname is not a valid GURL). Added comments.

[sky, 2016/06/16 17:42:49]

Can DidBlockContentType take a GURL then? Also, it's my understanding toString()
may not return a url. It returns something 'like' a url. For if the
websecurityorigin is empty toString() returns 'null'. How do you know you won't
hit that code path?

[estark, 2016/06/16 18:29:23]

Ah, that's a good point. It appears that this could indeed be empty if the
origin is, for example, sandboxed. My understanding, also, is that this string
argument is a generic details argument that can't simply be changed to a GURL.
(Other content settings type send other string values in the |details| argument,
IIUC.)

I don't think I can spend any more time on this. lgarron and/or jialiul, since
you did the original metric + fix, are either of you interested in taking this
over, now that there's a test for it?

Otherwise I think we should just revert the commit that introduced this metric
until someone has time to fix it properly.

[Jialiu Lin, 2016/06/16 20:47:17]

Here is the CL originally introduced this rappor metric.
https://codereview.chromium.org/1162123002
If nobody is actually consuming this rappor metric, I agree with estark that we
probably should simply revert it.

     return false;
   }
 
   return true;
 }
 
 bool ContentSettingsObserver::allowAutoplay(bool default_value) {
   if (!content_setting_rules_)
     return default_value;
 
@@ skipping 130 matching lines @@
 
   // If the scheme is file:, an empty file name indicates a directory listing,
   // which requires JavaScript to function properly.
   if (base::EqualsASCII(protocol, url::kFileScheme)) {
     return document_url.SchemeIs(url::kFileScheme) &&
            document_url.ExtractFileName().empty();
   }
 
   return false;
 }