Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: chrome/browser/first_run/first_run.h

Issue 20483002: Merge 3 different ways of obtaining first run state into a single one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r214457 -- fix conflict with r214339 -- dcommit since tests pass on previous patch set Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chrome_browser_main_win.cc ('k') | chrome/browser/first_run/first_run.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_ 5 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
6 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_ 6 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 // Options for the first run bubble. The default is FIRST_RUN_BUBBLE_DONT_SHOW. 55 // Options for the first run bubble. The default is FIRST_RUN_BUBBLE_DONT_SHOW.
56 // FIRST_RUN_BUBBLE_SUPPRESS is stronger in that FIRST_RUN_BUBBLE_SHOW should 56 // FIRST_RUN_BUBBLE_SUPPRESS is stronger in that FIRST_RUN_BUBBLE_SHOW should
57 // never be set once FIRST_RUN_BUBBLE_SUPPRESS is set. 57 // never be set once FIRST_RUN_BUBBLE_SUPPRESS is set.
58 enum FirstRunBubbleOptions { 58 enum FirstRunBubbleOptions {
59 FIRST_RUN_BUBBLE_DONT_SHOW, 59 FIRST_RUN_BUBBLE_DONT_SHOW,
60 FIRST_RUN_BUBBLE_SUPPRESS, 60 FIRST_RUN_BUBBLE_SUPPRESS,
61 FIRST_RUN_BUBBLE_SHOW, 61 FIRST_RUN_BUBBLE_SHOW,
62 }; 62 };
63 63
64 enum ProcessMasterPreferencesResult { 64 enum ProcessMasterPreferencesResult {
65 DO_FIRST_RUN_TASKS = 0, // Should do the first run tasks. 65 FIRST_RUN_PROCEED = 0, // Proceed with first run.
66 SKIP_FIRST_RUN_TASKS, // Should skip the first run tasks. 66 EULA_EXIT_NOW, // Should immediately exit due to EULA flow.
67 EULA_EXIT_NOW, // Should immediately exit due to EULA flow.
68 }; 67 };
69 68
70 // See ProcessMasterPreferences for more info about this structure. 69 // See ProcessMasterPreferences for more info about this structure.
71 struct MasterPrefs { 70 struct MasterPrefs {
72 MasterPrefs(); 71 MasterPrefs();
73 ~MasterPrefs(); 72 ~MasterPrefs();
74 73
75 // TODO(macourteau): as part of the master preferences refactoring effort, 74 // TODO(macourteau): as part of the master preferences refactoring effort,
76 // remove items from here which are being stored temporarily only to be later 75 // remove items from here which are being stored temporarily only to be later
77 // dumped into local_state. Also see related TODO in chrome_browser_main.cc. 76 // dumped into local_state. Also see related TODO in chrome_browser_main.cc.
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 const content::NotificationDetails& details) OVERRIDE; 192 const content::NotificationDetails& details) OVERRIDE;
194 193
195 content::NotificationRegistrar registrar_; 194 content::NotificationRegistrar registrar_;
196 195
197 DISALLOW_COPY_AND_ASSIGN(FirstRunBubbleLauncher); 196 DISALLOW_COPY_AND_ASSIGN(FirstRunBubbleLauncher);
198 }; 197 };
199 198
200 } // namespace first_run 199 } // namespace first_run
201 200
202 #endif // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_ 201 #endif // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
OLDNEW
« no previous file with comments | « chrome/browser/chrome_browser_main_win.cc ('k') | chrome/browser/first_run/first_run.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698