Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 2048233002: Add config so perbots test tamper detection experiment (Closed)

Created:
4 years, 6 months ago by bengr
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add config so perbots test tamper detection experiment Lists the tamper detection group in the list of experimental groups that should be tested by perfbots. BUG=597969 Committed: https://crrev.com/2f70f04d0f8acd71c910028841fc8b93730411f2 Cr-Commit-Position: refs/heads/master@{#399352}

Patch Set 1 #

Total comments: 2

Patch Set 2 : added params #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bengr
4 years, 6 months ago (2016-06-08 22:02:21 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-06-09 15:29:09 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/2048233002/diff/1/testing/variations/fieldtrial_testing_config_android.json File testing/variations/fieldtrial_testing_config_android.json (right): https://codereview.chromium.org/2048233002/diff/1/testing/variations/fieldtrial_testing_config_android.json#newcode105 testing/variations/fieldtrial_testing_config_android.json:105: "group_name": "TamperDetection_enabled" Actually, you should add a params section ...
4 years, 6 months ago (2016-06-09 21:48:15 UTC) #4
bengr
https://codereview.chromium.org/2048233002/diff/1/testing/variations/fieldtrial_testing_config_android.json File testing/variations/fieldtrial_testing_config_android.json (right): https://codereview.chromium.org/2048233002/diff/1/testing/variations/fieldtrial_testing_config_android.json#newcode105 testing/variations/fieldtrial_testing_config_android.json:105: "group_name": "TamperDetection_enabled" On 2016/06/09 21:48:14, Alexei Svitkine (OOO) wrote: ...
4 years, 6 months ago (2016-06-10 23:21:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048233002/20001
4 years, 6 months ago (2016-06-10 23:22:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-11 02:15:42 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-11 02:15:50 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 02:17:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f70f04d0f8acd71c910028841fc8b93730411f2
Cr-Commit-Position: refs/heads/master@{#399352}

Powered by Google App Engine
This is Rietveld 408576698