Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: src/interpreter/bytecode-pipeline.cc

Issue 2048203002: [interpreter] Minor clean-up of BytecodeSourceInfo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0066-suppress
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-pipeline.h ('k') | src/interpreter/bytecode-register-optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-pipeline.cc
diff --git a/src/interpreter/bytecode-pipeline.cc b/src/interpreter/bytecode-pipeline.cc
index 89d9ad6cfdda61d70c4b756daf99dd80bae6e72f..58ade92264da0488271efb74120de2a65104a06a 100644
--- a/src/interpreter/bytecode-pipeline.cc
+++ b/src/interpreter/bytecode-pipeline.cc
@@ -11,26 +11,6 @@ namespace v8 {
namespace internal {
namespace interpreter {
-void BytecodeSourceInfo::Update(const BytecodeSourceInfo& entry) {
- if (!entry.is_valid()) return;
-
- if (!is_valid() || (entry.is_statement() && !is_statement()) ||
- (entry.is_statement() && is_statement() &&
- entry.source_position() > source_position())) {
- // Position is updated if any of the following conditions are met:
- // (1) there is no existing position.
- // (2) the incoming position is a statement and the current position
- // is an expression.
- // (3) the existing position is a statement and the incoming
- // statement has a later source position.
- // Condition 3 is needed for the first statement in a function which
- // may end up with later statement positions being added during bytecode
- // generation.
- source_position_ = entry.source_position_;
- is_statement_ = entry.is_statement_;
- }
-}
-
BytecodeNode::BytecodeNode(Bytecode bytecode) {
DCHECK_EQ(Bytecodes::NumberOfOperands(bytecode), 0);
bytecode_ = bytecode;
« no previous file with comments | « src/interpreter/bytecode-pipeline.h ('k') | src/interpreter/bytecode-register-optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698