Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: ui/display/chromeos/output_configurator.cc

Issue 204813006: Adds UMA for display color calibration in ChromeOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/display/chromeos/output_configurator.cc
diff --git a/ui/display/chromeos/output_configurator.cc b/ui/display/chromeos/output_configurator.cc
index cd95866f00aa168b986c92cbf0b9a52c0eef2923..f0679ee6bc5c8bd633d7eea80ab2819e09c99ac9 100644
--- a/ui/display/chromeos/output_configurator.cc
+++ b/ui/display/chromeos/output_configurator.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/logging.h"
+#include "base/metrics/histogram.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/sys_info.h"
@@ -399,8 +400,15 @@ bool OutputConfigurator::SetColorCalibrationProfile(
for (size_t i = 0; i < cached_outputs_.size(); ++i) {
if (cached_outputs_[i].display &&
cached_outputs_[i].display->display_id() == display_id) {
- return native_display_delegate_->SetColorCalibrationProfile(
+ bool succeed = native_display_delegate_->SetColorCalibrationProfile(
*cached_outputs_[i].display, new_profile);
+ if (succeed) {
+ UMA_HISTOGRAM_ENUMERATION(
+ "ChromeOS.Display.ColorProfile",
+ new_profile,
+ COLOR_PROFILE_READING + 1);
Alexei Svitkine (slow) 2014/03/26 13:02:10 Can you add a new enum at the end for the size ins
Jun Mukai 2014/03/26 18:08:09 Done.
+ }
+ return succeed;
}
}

Powered by Google App Engine
This is Rietveld 408576698