Adds UMA for display color calibration in ChromeOS.

Adds UMA for display color calibration in ChromeOS.

BUG=355861
R=oshima@chromium.org, asvitkine@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259952

[oshima, 2014-03-26 00:11:20]

lgtm

[Jun Mukai, 2014-03-26 00:20:17]

asvitkine, please check tools/metrics as the owner.

[Alexei Svitkine (slow), 2014-03-26 13:02:09]

https://codereview.chromium.org/204813006/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/204813006/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:2012: <description>Please enter the
description of the metric.</description>
This is missing a description.

Also, does it need to be an action rather than a histogram? (the difference is
that our dashboards have better support for histograms while actions havr timing
information internally which is only accessible through custom analysis scripts)

https://codereview.chromium.org/204813006/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/204813006/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:2042: +    The name of the color
calibration of the display on ChromeOS.
Can you mention when this is logged? On user login? On device startup? Only when
it changes?

https://codereview.chromium.org/204813006/diff/1/ui/display/chromeos/output_c...
File ui/display/chromeos/output_configurator.cc (right):

https://codereview.chromium.org/204813006/diff/1/ui/display/chromeos/output_c...
ui/display/chromeos/output_configurator.cc:409: COLOR_PROFILE_READING + 1);
Can you add a new enum at the end for the size instead of adding 1 to some enum?
(Else if there's a new enum value added, this won't be correct anymore.)

https://codereview.chromium.org/204813006/diff/1/ui/display/display_constants.h
File ui/display/display_constants.h (right):

https://codereview.chromium.org/204813006/diff/1/ui/display/display_constants...
ui/display/display_constants.h:40: // Color calibration profiles. When you
change this enum or its order, edit
Nit: Comment should say "don't change the order".

[Jun Mukai, 2014-03-26 18:08:09]

https://codereview.chromium.org/204813006/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/204813006/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:2012: <description>Please enter the
description of the metric.</description>
On 2014/03/26 13:02:10, Alexei Svitkine wrote:
> This is missing a description.
> 
> Also, does it need to be an action rather than a histogram? (the difference is
> that our dashboards have better support for histograms while actions havr
timing
> information internally which is only accessible through custom analysis
scripts)

Added the description.

Correct me if I'm wrong, but I think histogram total count is the total number
of the users who change the color profile. My intention of this action is to see
how many times users change this, because a user may change it upon a specific
situation (to choose 'movie' profile when watching videos, for example). If
histogram doesn't work in that way, I'll remove this.

https://codereview.chromium.org/204813006/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/204813006/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:2042: +    The name of the color
calibration of the display on ChromeOS.
On 2014/03/26 13:02:10, Alexei Svitkine wrote:
> Can you mention when this is logged? On user login? On device startup? Only
when
> it changes?

added.

https://codereview.chromium.org/204813006/diff/1/ui/display/chromeos/output_c...
File ui/display/chromeos/output_configurator.cc (right):

https://codereview.chromium.org/204813006/diff/1/ui/display/chromeos/output_c...
ui/display/chromeos/output_configurator.cc:409: COLOR_PROFILE_READING + 1);
On 2014/03/26 13:02:10, Alexei Svitkine wrote:
> Can you add a new enum at the end for the size instead of adding 1 to some
enum?
> (Else if there's a new enum value added, this won't be correct anymore.)

Done.

https://codereview.chromium.org/204813006/diff/1/ui/display/display_constants.h
File ui/display/display_constants.h (right):

https://codereview.chromium.org/204813006/diff/1/ui/display/display_constants...
ui/display/display_constants.h:40: // Color calibration profiles. When you
change this enum or its order, edit
On 2014/03/26 13:02:10, Alexei Svitkine wrote:
> Nit: Comment should say "don't change the order".

Done.

[Jun Mukai, 2014-03-26 18:09:05]

Also noticed that my code might not send the histogram data correctly in some
case, so changed the code (moved from output_configurator to display_manager).

oshima, please review this again...

[Alexei Svitkine (slow), 2014-03-26 19:18:08]

https://codereview.chromium.org/204813006/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/204813006/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:2012: <description>Please enter the
description of the metric.</description>
On 2014/03/26 18:08:09, Jun Mukai wrote:
> On 2014/03/26 13:02:10, Alexei Svitkine wrote:
> > This is missing a description.
> > 
> > Also, does it need to be an action rather than a histogram? (the difference
is
> > that our dashboards have better support for histograms while actions havr
> timing
> > information internally which is only accessible through custom analysis
> scripts)
> 
> Added the description.
> 
> Correct me if I'm wrong, but I think histogram total count is the total number
> of the users who change the color profile. My intention of this action is to
see
> how many times users change this, because a user may change it upon a specific
> situation (to choose 'movie' profile when watching videos, for example). If
> histogram doesn't work in that way, I'll remove this.

The histogram dashboard has two views.

The default view shows counts (not users), so you'd see the number of changes
total. There's a checkbox called "show user counts" that instead shows the
number of unique users that reported each bucket.

[Jun Mukai, 2014-03-26 21:17:46]

https://codereview.chromium.org/204813006/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/204813006/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:2012: <description>Please enter the
description of the metric.</description>
On 2014/03/26 19:18:08, Alexei Svitkine wrote:
> On 2014/03/26 18:08:09, Jun Mukai wrote:
> > On 2014/03/26 13:02:10, Alexei Svitkine wrote:
> > > This is missing a description.
> > > 
> > > Also, does it need to be an action rather than a histogram? (the
difference
> is
> > > that our dashboards have better support for histograms while actions havr
> > timing
> > > information internally which is only accessible through custom analysis
> > scripts)
> > 
> > Added the description.
> > 
> > Correct me if I'm wrong, but I think histogram total count is the total
number
> > of the users who change the color profile. My intention of this action is to
> see
> > how many times users change this, because a user may change it upon a
specific
> > situation (to choose 'movie' profile when watching videos, for example). If
> > histogram doesn't work in that way, I'll remove this.
> 
> The histogram dashboard has two views.
> 
> The default view shows counts (not users), so you'd see the number of changes
> total. There's a checkbox called "show user counts" that instead shows the
> number of unique users that reported each bucket.

ah, got it. removed. thanks!

[Alexei Svitkine (slow), 2014-03-26 21:35:54]

lgtm

https://codereview.chromium.org/204813006/diff/160001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/204813006/diff/160001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2101: +    value is sent when the color
calibration has changed by the user.
Nit: has -> is

[Jun Mukai, 2014-03-26 23:00:12]

https://codereview.chromium.org/204813006/diff/160001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/204813006/diff/160001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2101: +    value is sent when the color
calibration has changed by the user.
On 2014/03/26 21:35:54, Alexei Svitkine wrote:
> Nit: has -> is

Done.

[oshima, 2014-03-26 23:20:29]

lgtm

[Jun Mukai, 2014-03-26 23:40:05]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-03-26 23:41:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/204813006/180001

[commit-bot: I haz the power, 2014-03-27 04:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 04:05:01]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[Jun Mukai, 2014-03-27 04:12:18]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-03-27 04:13:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/204813006/180001

[commit-bot: I haz the power, 2014-03-27 05:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 05:21:17]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_clang_dbg
  tryserver.chromium on linux_chromium_chromeos_rel

[Jun Mukai, 2014-03-27 05:44:03]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-03-27 05:44:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/204813006/200001

[commit-bot: I haz the power, 2014-03-27 07:18:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 07:18:08]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[Jun Mukai, 2014-03-27 17:02:03]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-03-27 17:03:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/204813006/200001

[commit-bot: I haz the power, 2014-03-27 19:31:12]

Change committed as 259952