Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: media/cast/test/cast_benchmarks.cc

Issue 2048033003: Refactoring: CastTransport InitializeAudio/InitializeVideo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/test/cast_benchmarks.cc
diff --git a/media/cast/test/cast_benchmarks.cc b/media/cast/test/cast_benchmarks.cc
index 4bebe4a02d460cb712a505efa26ed5aa3a52dca1..08fc8eae70cdebca2246df8ff7730ec3ae99c67f 100644
--- a/media/cast/test/cast_benchmarks.cc
+++ b/media/cast/test/cast_benchmarks.cc
@@ -97,16 +97,10 @@ class CastTransportWrapper : public CastTransport {
encoded_audio_bytes_ = encoded_audio_bytes;
}
- void InitializeAudio(const CastTransportRtpConfig& config,
- std::unique_ptr<RtcpObserver> rtcp_observer) final {
+ void InitializeStream(const CastTransportRtpConfig& config,
+ std::unique_ptr<RtcpObserver> rtcp_observer) final {
audio_ssrc_ = config.ssrc;
miu 2016/07/06 21:45:42 Need to set video_ssrc_ instead, if this is video.
xjz 2016/07/13 20:31:17 Done.
- transport_->InitializeAudio(config, std::move(rtcp_observer));
- }
-
- void InitializeVideo(const CastTransportRtpConfig& config,
- std::unique_ptr<RtcpObserver> rtcp_observer) final {
- video_ssrc_ = config.ssrc;
- transport_->InitializeVideo(config, std::move(rtcp_observer));
+ transport_->InitializeStream(config, std::move(rtcp_observer));
}
void InsertFrame(uint32_t ssrc, const EncodedFrame& frame) final {
@@ -455,9 +449,7 @@ class TransportClient : public CastTransport::Client {
: run_one_benchmark_(run_one_benchmark) {}
void OnStatusChanged(CastTransportStatus status) final {
- bool result = (status == TRANSPORT_AUDIO_INITIALIZED ||
- status == TRANSPORT_VIDEO_INITIALIZED);
- EXPECT_TRUE(result);
+ EXPECT_EQ(TRANSPORT_STREAM_INITIALIZED, status);
};
void OnLoggingEventsReceived(
std::unique_ptr<std::vector<FrameEvent>> frame_events,

Powered by Google App Engine
This is Rietveld 408576698