Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(330)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/media/controls-drag-timebar-expected.txt
Issue
204803002
:
Make scrubbing a MediaControls-internal concept (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: check mediaControllerInterface().paused()
Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/media/controls-drag-timebar.html
LayoutTests/media/controls-drag-timebar-expected.txt
Source/core/html/HTMLMediaElement.h
Source/core/html/HTMLMediaElement.cpp
Source/core/html/MediaController.h
Source/core/html/MediaController.cpp
Source/core/html/MediaControllerInterface.h
Source/core/html/shadow/MediaControlElements.cpp
Source/core/html/shadow/MediaControls.h
Source/core/html/shadow/MediaControls.cpp
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/media/controls-drag-timebar.html
('k') |
Source/core/html/HTMLMediaElement.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 Test that dragging the timebar thumb causes seeks.
1 Test that dragging the timebar thumb causes seeks.
2
2
3
EVENT(
canplaythrough
)
3
EVENT(
playing
)
4
EXPECTED (video.paused == 'false') OK
5
EXPECTED (video.paused == 'true') OK
4 EVENT(seeked)
6 EVENT(seeked)
5 EVENT(seeked)
7 EVENT(seeked)
6 EVENT(seeked)
8 EVENT(seeked)
7 EVENT(seeked)
9 EVENT(seeked)
8 EVENT(seeked)
10 EVENT(seeked)
9 EVENT(seeked)
11 EVENT(seeked)
12
EXPECTED (video.paused == 'true') OK
13
EXPECTED (video.paused == 'false') OK
10 END OF TEST
14 END OF TEST
11
15
OLD
NEW
« no previous file with comments
|
« LayoutTests/media/controls-drag-timebar.html
('k') |
Source/core/html/HTMLMediaElement.h »
('j') |
no next file with comments »
Issue 204803002: Make scrubbing a MediaControls-internal concept (Closed)
Created 6 years, 9 months ago by philipj_slow
Modified 6 years, 9 months ago
Reviewers: acolwell GONE FROM CHROMIUM
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 4
This is Rietveld
408576698
Chromium Code Reviews
Issue 204803002:
Make scrubbing a MediaControls-internal concept (Closed)
Base URL: svn://svn.chromium.org/blink/trunk