Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1848)

Unified Diff: base/bind_internal.h

Issue 2048023004: Introduce base::IsWeakReceiver for base::Bind to support external weak pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: +comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/bind_helpers.h ('K') | « base/bind_helpers.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/bind_internal.h
diff --git a/base/bind_internal.h b/base/bind_internal.h
index 4da13eed99d20a001e08c564f3fd7818d9549955..17dbfa3a762d2bfe3cfb44f80a1ae3c103a451dc 100644
--- a/base/bind_internal.h
+++ b/base/bind_internal.h
@@ -319,11 +319,11 @@ struct InvokeHelper<true, void> {
static void MakeItSo(Runnable&& runnable,
BoundWeakPtr weak_ptr,
RunArgs&&... args) {
- if (!weak_ptr.get()) {
+ if (!weak_ptr) {
return;
}
std::forward<Runnable>(runnable).Run(
- weak_ptr.get(), std::forward<RunArgs>(args)...);
+ weak_ptr, std::forward<RunArgs>(args)...);
danakj 2016/06/10 23:36:18 I had to look at a bunch of places to understand w
tzik 2016/06/14 12:06:10 Done.
}
};
« base/bind_helpers.h ('K') | « base/bind_helpers.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698