Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2047993002: Initial repo setup for third party library CED (Closed)

Created:
4 years, 6 months ago by Jinsuk Kim
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initial repo setup for third party library CED Initializes src/third_party/ced for CED, open-source library used to detect texting encoding automatically. This library is intended to replace ICU used in Blink for automatic text encoding detection feature. The feature, when enabled, helps web pages coming without encoding label displayed as expected instead of showing gibberish. The feature is disabled by default despite its usefulness, since it slows down the page loading for those unlabeled ones (about 2% of total pages) down to 20~30% in some cases. It is left to users to turn it on via UI. CED is used extensively in Google, and is a better alternative in terms of accuracy, speed, size, etc. Experiments show that CED introduces no significant load. With CED in place, it is possible that automatic encoding detection can be turned on by default without introducing regression in page loading time. This will be particularly beneficial on mobile platform like Android where UI has more limitations. It will just work without individual users having to turn it on. BUG=597488 Committed: https://crrev.com/21d3369fc5ab4d70732f4d83388ad2e144aaebcb Cr-Commit-Position: refs/heads/master@{#400906}

Patch Set 1 #

Patch Set 2 : deps #

Patch Set 3 : updated sha-1 to fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -1 line) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/ced/BUILD.gn View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
A + third_party/ced/LICENSE View 1 chunk +1 line, -1 line 0 comments Download
A third_party/ced/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/ced/README.chromium View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/ced/ced.gyp View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Ryan Sleevi
Drive-by from the peanut gallery: Do you have a BUG that you can attach this ...
4 years, 6 months ago (2016-06-09 02:55:34 UTC) #3
Jinsuk Kim
Discussion in the bug https://bugs.chromium.org/p/chromium/issues/detail?id=597488#c17 and forward outlines the way this will be used. Just ...
4 years, 6 months ago (2016-06-09 03:04:18 UTC) #6
Jinsuk Kim
Got an approval from open source 3rd-party review. This CL simply adds files necessary to ...
4 years, 6 months ago (2016-06-13 23:15:31 UTC) #9
Jinsuk Kim
On 2016/06/13 23:15:31, Jinsuk wrote: > Got an approval from open source 3rd-party review. This ...
4 years, 6 months ago (2016-06-15 01:21:00 UTC) #10
brettw
LGTM, sorry I lost this!
4 years, 6 months ago (2016-06-15 04:52:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047993002/20001
4 years, 6 months ago (2016-06-21 01:02:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/249393)
4 years, 6 months ago (2016-06-21 02:31:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047993002/40001
4 years, 6 months ago (2016-06-21 06:12:11 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-21 06:16:27 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 06:17:57 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/21d3369fc5ab4d70732f4d83388ad2e144aaebcb
Cr-Commit-Position: refs/heads/master@{#400906}

Powered by Google App Engine
This is Rietveld 408576698