Issue 204793004: Makes View::RecreateLayer() and Window::RecreateLayer() the same

Issue 204793004: Makes View::RecreateLayer() and Window::RecreateLayer() the same (Closed)

Created:
6 years, 9 months ago by sky

Modified:
6 years, 9 months ago

Reviewers:
oshima

CC:
chromium-reviews, sadrul, kalyank, Ian Vollick, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, ben+views_chromium.org, piman+watch_chromium.org, ben+aura_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Makes View::RecreateLayer() and Window::RecreateLayer() the same In particular they both need to move all of the children from the old layer to the newly created layer. BUG=none TEST=covered by test now R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258115

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Total comments: 4

Patch Set 3 : merge 2 trunk #

Patch Set 4 : review comments #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -55 lines)			Patch
M	ui/aura/window.cc	View	1 2	3 chunks	+12 lines, -39 lines	0 comments	Download
A	ui/compositor/clone_layer.h	View	1 2 3	1 chunk	+23 lines, -0 lines	0 comments	Download
A	ui/compositor/clone_layer.cc	View	1 2 3	1 chunk	+54 lines, -0 lines	0 comments	Download
M	ui/compositor/compositor.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/compositor/debug_utils.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/compositor/debug_utils.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/view.cc	View		2 chunks	+2 lines, -7 lines	0 comments	Download
M	ui/views/view_unittest.cc	View		2 chunks	+35 lines, -7 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

sky

https://codereview.chromium.org/204793004/diff/1/ui/aura/window.cc File ui/aura/window.cc (left): https://codereview.chromium.org/204793004/diff/1/ui/aura/window.cc#oldcode298 ui/aura/window.cc:298: delegate_->DidRecreateLayer(old_layer.get(), layer()); You'll notice this is now invoked after ...

6 years, 9 months ago (2014-03-19 17:55:28 UTC) #1

oshima

thank you for prompt fix! lgtm https://codereview.chromium.org/204793004/diff/1/ui/aura/window.cc File ui/aura/window.cc (left): https://codereview.chromium.org/204793004/diff/1/ui/aura/window.cc#oldcode298 ui/aura/window.cc:298: delegate_->DidRecreateLayer(old_layer.get(), layer()); On ...

6 years, 9 months ago (2014-03-19 18:12:43 UTC) #2

sky

https://codereview.chromium.org/204793004/diff/10001/ui/compositor/clone_layer.cc File ui/compositor/clone_layer.cc (right): https://codereview.chromium.org/204793004/diff/10001/ui/compositor/clone_layer.cc#newcode54 ui/compositor/clone_layer.cc:54: } // namespace ui That's what I get for ...

6 years, 9 months ago (2014-03-19 18:24:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/204793004/40001

6 years, 9 months ago (2014-03-19 18:25:11 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-19 18:42:05 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel

6 years, 9 months ago (2014-03-19 18:42:06 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/204793004/40001

6 years, 9 months ago (2014-03-19 19:43:15 UTC) #9

Message was sent while issue was closed.

Change committed as 258115

Expand Messages | Collapse Messages