third_party/WebKit/Source/core/css/cssom/CSSTranslation.h - Issue 2047923002: [WIP] Add support for CSSValue-> CSSLengthValue and CSSTranslation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSTranslation.h

Issue 2047923002: [WIP] Add support for CSSValue-> CSSLengthValue and CSSTranslation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@supported-types

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.cpp ('k') | third_party/WebKit/Source/core/css/cssom/CSSTranslation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/CSSTranslation.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h b/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h

index e5ea97f1a3ceb61a2901909e1f503daed3140335..fbdb11aaa85e237e5ec41e108e03609ffc64c4a7 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h

@@ -18,11 +18,15 @@ class CORE_EXPORT CSSTranslation final : public TransformComponent {

public:

static CSSTranslation* create(CSSLengthValue* x, CSSLengthValue* y, ExceptionState&)

{

+ return CSSTranslation::create(x, y);

+ }

+ static CSSTranslation* create(CSSLengthValue* x, CSSLengthValue* y)

+ {

return new CSSTranslation(x, y, nullptr);

}

static CSSTranslation* create(CSSLengthValue* x, CSSLengthValue* y, CSSLengthValue* z, ExceptionState&);

- static CSSTranslation* fromCSSValue(const CSSValue& value) { return nullptr; }

+ static CSSTranslation* fromCSSValue(const CSSValue& value);

CSSLengthValue* x() const { return m_x; }

CSSLengthValue* y() const { return m_y; }