third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h - Issue 2047923002: [WIP] Add support for CSSValue-> CSSLengthValue and CSSTranslation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h

Issue 2047923002: [WIP] Add support for CSSValue-> CSSLengthValue and CSSTranslation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@supported-types

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp ('k') | third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h b/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h

index 9d3de5913738103acb5dd35c2242811ae3751339..99140c56ffd338749108ee20f311c9d64db6089c 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h

@@ -17,6 +17,7 @@ class CORE_EXPORT CSSLengthValue : public CSSStyleValue {

WTF_MAKE_NONCOPYABLE(CSSLengthValue);

DEFINE_WRAPPERTYPEINFO();

public:

+ static CSSLengthValue* fromCSSValue(const CSSValue& value);

static CSSPrimitiveValue::UnitType unitFromName(const String& name);

CSSLengthValue* add(const CSSLengthValue* other, ExceptionState&);

@@ -35,8 +36,8 @@ protected:

virtual CSSLengthValue* addInternal(const CSSLengthValue* other, ExceptionState&);

virtual CSSLengthValue* subtractInternal(const CSSLengthValue* other, ExceptionState&);

- virtual CSSLengthValue* multiplyInternal(double, ExceptionState&);

- virtual CSSLengthValue* divideInternal(double, ExceptionState&);

+ virtual CSSLengthValue* multiplyInternal(double);

+ virtual CSSLengthValue* divideInternal(double);

static bool isSupportedLengthUnit(CSSPrimitiveValue::UnitType unit)

{