Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2047843002: [Third Party] Add Android-Accessibility-Framework jar to Chromium (Closed)

Created:
4 years, 6 months ago by mikecase (-- gone --)
Modified:
4 years, 5 months ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Third Party] Add Android-Accessibility-Framework jar to Chromium This jar is a dependency for Robolectric 3.0. BUG=522043 Committed: https://crrev.com/840bb0f5eda052f9d0da148ced3a04610c4dc02d Cr-Commit-Position: refs/heads/master@{#403341}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : Updated DEPS file. #

Total comments: 2

Patch Set 5 : testonly, change - to _ #

Patch Set 6 : Added "_java" to target name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -0 lines) Patch
M .gitignore View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/accessibility_test_framework/BUILD.gn View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/accessibility_test_framework/LICENSE View 1 2 3 4 1 chunk +202 lines, -0 lines 0 comments Download
A third_party/accessibility_test_framework/OWNERS View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/accessibility_test_framework/README.chromium View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/accessibility_test_framework/lib/accessibility-test-framework-1.0.jar.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
mikecase (-- gone --)
4 years, 6 months ago (2016-06-07 23:33:36 UTC) #2
the real yoland
https://codereview.chromium.org/2047843002/diff/20001/DEPS File DEPS (right): https://codereview.chromium.org/2047843002/diff/20001/DEPS#newcode601 DEPS:601: 'src/build/android/update_third_party_deps.py', it's actually in src/build/android/update_third_party_deps/update_third_party_deps.py :(
4 years, 6 months ago (2016-06-09 18:55:06 UTC) #3
mikecase (-- gone --)
+klobag for third_party/ review Got open-source approval via email. Tested running "gclient runhooks" locally. This ...
4 years, 6 months ago (2016-06-22 21:21:17 UTC) #5
the real yoland
lgtm
4 years, 6 months ago (2016-06-22 21:23:38 UTC) #6
jbudorick
I think the directories should be libraries_with_underscores rather than libraries-with-dashes. https://codereview.chromium.org/2047843002/diff/60001/third_party/accessibility-test-framework/BUILD.gn File third_party/accessibility-test-framework/BUILD.gn (right): https://codereview.chromium.org/2047843002/diff/60001/third_party/accessibility-test-framework/BUILD.gn#newcode7 ...
4 years, 5 months ago (2016-06-27 13:26:58 UTC) #7
mikecase (-- gone --)
https://codereview.chromium.org/2047843002/diff/60001/third_party/accessibility-test-framework/BUILD.gn File third_party/accessibility-test-framework/BUILD.gn (right): https://codereview.chromium.org/2047843002/diff/60001/third_party/accessibility-test-framework/BUILD.gn#newcode7 third_party/accessibility-test-framework/BUILD.gn:7: java_prebuilt("accessibility_test_framework") { On 2016/06/27 at 13:26:58, jbudorick (EMEA til ...
4 years, 5 months ago (2016-06-27 17:46:40 UTC) #8
klobag.chromium
lgtm
4 years, 5 months ago (2016-06-29 18:29:18 UTC) #9
jbudorick
lgtm
4 years, 5 months ago (2016-06-30 08:16:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2047843002/100001
4 years, 5 months ago (2016-06-30 22:44:48 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-06-30 23:37:23 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 23:37:26 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:39:32 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/840bb0f5eda052f9d0da148ced3a04610c4dc02d
Cr-Commit-Position: refs/heads/master@{#403341}

Powered by Google App Engine
This is Rietveld 408576698