Create .gyp rules for shaderc libraries

Create .gyp rules for shaderc libraries

To build shaderc, gyp used to punt to cmake, which did not work well on the bots and I couldn't find any way to pipe the variables into cmake which would have made it happy.

So, I wrote a gyp file for shaderc and its dependencies.  Nothing super complicated (thank goodness), except for the files that spirv-tools needed generated.

BUG=skia:5186
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047833003

Committed: https://skia.googlesource.com/skia/+/b7b4293524e0c1d4c1635c4710aceafaca47b313

[kjlubick, 2016-06-08 20:03:26]

Description was changed from

==========
Creating .gyp rules for shaderc libraries

BUG=skia:
==========

to

==========
Creating .gyp rules for shaderc libraries

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047833003
==========

[kjlubick, 2016-06-09 19:29:00]

The CQ bit was checked by kjlubick@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 19:29:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047833003/40001

[kjlubick, 2016-06-10 15:04:16]

kjlubick@google.com changed reviewers:
+ bungeman@google.com

[kjlubick, 2016-06-10 15:06:11]

Description was changed from

==========
Creating .gyp rules for shaderc libraries

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047833003
==========

to

==========
Create .gyp rules for shaderc libraries

To build shaderc, gyp used to punt to cmake, which did not work well on the bots
and I couldn't find any way to pipe the variables into cmake which would have
made it happy.

So, I wrote a gyp file for shaderc and its dependencies.  Nothing super
complicated (thank goodness), except for the files that spirv-tools needed
generated.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047833003
==========

[bungeman-skia, 2016-06-10 15:48:56]

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp
File gyp/shaderc.gyp (right):

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcode8
gyp/shaderc.gyp:8: 'targets': [
Generally we use two space indents in gyp files. Keeps lines from getting too
long.

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcode20
gyp/shaderc.gyp:20: 'defines': [],
I would remove all of these properties with empty values.

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcode29
gyp/shaderc.gyp:29: ],
This line and the one above should be un-indented two spaces. Similarly in
several other places.

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcode41
gyp/shaderc.gyp:41: },
Should be able to just remove this whole block.

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcod...
gyp/shaderc.gyp:176: }, {
We normally would un-indent this two spaces (and the bodies of both cases).

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcod...
gyp/shaderc.gyp:298: 'actions': [
It's annoying that these actions almost look like they could be rules, but
apparently they're all different enough that they need to be separate actions.

[kjlubick, 2016-06-10 16:28:41]

Description was changed from

==========
Create .gyp rules for shaderc libraries

To build shaderc, gyp used to punt to cmake, which did not work well on the bots
and I couldn't find any way to pipe the variables into cmake which would have
made it happy.

So, I wrote a gyp file for shaderc and its dependencies.  Nothing super
complicated (thank goodness), except for the files that spirv-tools needed
generated.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047833003
==========

to

==========
Create .gyp rules for shaderc libraries

To build shaderc, gyp used to punt to cmake, which did not work well on the bots
and I couldn't find any way to pipe the variables into cmake which would have
made it happy.

So, I wrote a gyp file for shaderc and its dependencies.  Nothing super
complicated (thank goodness), except for the files that spirv-tools needed
generated.

BUG=skia:5186
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047833003
==========

[kjlubick, 2016-06-10 17:37:53]

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp
File gyp/shaderc.gyp (right):

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcode8
gyp/shaderc.gyp:8: 'targets': [
On 2016/06/10 at 15:48:56, bungeman-skia wrote:
> Generally we use two space indents in gyp files. Keeps lines from getting too
long.

Done.

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcode20
gyp/shaderc.gyp:20: 'defines': [],
On 2016/06/10 at 15:48:56, bungeman-skia wrote:
> I would remove all of these properties with empty values.

Done.

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcode29
gyp/shaderc.gyp:29: ],
On 2016/06/10 at 15:48:56, bungeman-skia wrote:
> This line and the one above should be un-indented two spaces. Similarly in
several other places.

Done.

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcode41
gyp/shaderc.gyp:41: },
On 2016/06/10 at 15:48:56, bungeman-skia wrote:
> Should be able to just remove this whole block.

Done.

https://codereview.chromium.org/2047833003/diff/120001/gyp/shaderc.gyp#newcod...
gyp/shaderc.gyp:176: }, {
On 2016/06/10 at 15:48:56, bungeman-skia wrote:
> We normally would un-indent this two spaces (and the bodies of both cases).

Done.

[bungeman-skia, 2016-06-10 18:40:40]

I see nothing wrong with it. If it works, ship it! lgtm

[kjlubick, 2016-06-10 18:44:21]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-06-10 18:44:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047833003/140001

[commit-bot: I haz the power, 2016-06-10 19:07:52]

Description was changed from

==========
Create .gyp rules for shaderc libraries

To build shaderc, gyp used to punt to cmake, which did not work well on the bots
and I couldn't find any way to pipe the variables into cmake which would have
made it happy.

So, I wrote a gyp file for shaderc and its dependencies.  Nothing super
complicated (thank goodness), except for the files that spirv-tools needed
generated.

BUG=skia:5186
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047833003
==========

to

==========
Create .gyp rules for shaderc libraries

To build shaderc, gyp used to punt to cmake, which did not work well on the bots
and I couldn't find any way to pipe the variables into cmake which would have
made it happy.

So, I wrote a gyp file for shaderc and its dependencies.  Nothing super
complicated (thank goodness), except for the files that spirv-tools needed
generated.

BUG=skia:5186
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047833003

Committed:
https://skia.googlesource.com/skia/+/b7b4293524e0c1d4c1635c4710aceafaca47b313
==========

[commit-bot: I haz the power, 2016-06-10 19:07:53]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/b7b4293524e0c1d4c1635c4710aceafaca47b313