Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: content/browser/devtools/site_per_process_devtools_browsertest.cc

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/shared_worker_devtools_manager_unittest.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/site_per_process_devtools_browsertest.cc
diff --git a/content/browser/devtools/site_per_process_devtools_browsertest.cc b/content/browser/devtools/site_per_process_devtools_browsertest.cc
index e3c3cf222bc3cf1cbcb1bb12675ceaebf7e332e2..1cd0052fa6931bdfdaa44d5d89af0f58ac9d62da 100644
--- a/content/browser/devtools/site_per_process_devtools_browsertest.cc
+++ b/content/browser/devtools/site_per_process_devtools_browsertest.cc
@@ -110,9 +110,9 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
// Send message to parent and child frames and get result back.
char message[] = "{\"id\": 0, \"method\": \"incorrect.method\"}";
- child_host->DispatchProtocolMessage(message);
+ child_host->DispatchProtocolMessage(&child_client, message);
child_client.WaitForReply();
- parent_host->DispatchProtocolMessage(message);
+ parent_host->DispatchProtocolMessage(&parent_client, message);
parent_client.WaitForReply();
// Load back same-site page into iframe.
@@ -123,10 +123,10 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
EXPECT_EQ(DevToolsAgentHost::TYPE_WEB_CONTENTS, list[0]->GetType());
EXPECT_EQ(main_url.spec(), list[0]->GetURL().spec());
EXPECT_TRUE(child_client.closed());
- child_host->DetachClient();
+ child_host->DetachClient(&child_client);
child_host = nullptr;
EXPECT_FALSE(parent_client.closed());
- parent_host->DetachClient();
+ parent_host->DetachClient(&parent_client);
parent_host = nullptr;
}
« no previous file with comments | « content/browser/devtools/shared_worker_devtools_manager_unittest.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698