Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: content/browser/devtools/devtools_manager_unittest.cc

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_manager_unittest.cc
diff --git a/content/browser/devtools/devtools_manager_unittest.cc b/content/browser/devtools/devtools_manager_unittest.cc
index 3aee809d9278a6b64f03cca9846409ef15e0c0ea..31abbec6c5937018464fa7d811cc57b4d4c472db 100644
--- a/content/browser/devtools/devtools_manager_unittest.cc
+++ b/content/browser/devtools/devtools_manager_unittest.cc
@@ -44,7 +44,7 @@ class TestDevToolsClientHost : public DevToolsAgentHostClient {
void Close() {
EXPECT_FALSE(closed_);
close_counter++;
- agent_host_->DetachClient();
+ agent_host_->DetachClient(this);
closed_ = true;
}
@@ -247,9 +247,9 @@ TEST_F(DevToolsManagerTest, TestExternalProxy) {
TestDevToolsClientHost client_host;
client_host.InspectAgentHost(agent_host.get());
- agent_host->DispatchProtocolMessage("message1");
- agent_host->DispatchProtocolMessage("message2");
- agent_host->DispatchProtocolMessage("message2");
+ agent_host->DispatchProtocolMessage(&client_host, "message1");
+ agent_host->DispatchProtocolMessage(&client_host, "message2");
+ agent_host->DispatchProtocolMessage(&client_host, "message2");
client_host.Close();
}
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/browser/devtools/protocol/browser_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698