Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.h
diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h
index f70ebc5fc97dec4bf1cae5315a585aff3634d002..ddd2917e4b57133908eb12c278c25b6c912389ca 100644
--- a/content/browser/devtools/devtools_agent_host_impl.h
+++ b/content/browser/devtools/devtools_agent_host_impl.h
@@ -38,8 +38,12 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost,
bool Inspect(BrowserContext* browser_context);
// DevToolsAgentHost implementation.
- void AttachClient(DevToolsAgentHostClient* client) override;
- void DetachClient() override;
+ bool AttachClient(DevToolsAgentHostClient* client) override;
+ void ForceAttachClient(DevToolsAgentHostClient* client) override;
+ bool DetachClient(DevToolsAgentHostClient* client) override;
+ bool DispatchProtocolMessage(DevToolsAgentHostClient* client,
+ const std::string& message) override;
+
bool IsAttached() override;
void InspectElement(int x, int y) override;
std::string GetId() override;
@@ -57,6 +61,8 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost,
DevToolsAgentHostImpl();
~DevToolsAgentHostImpl() override;
+ virtual bool DispatchProtocolMessage(const std::string& message) = 0;
+
void HostClosed();
void SendMessageToClient(int session_id, const std::string& message);
devtools::DevToolsIOContext* GetIOContext() { return &io_context_; }
@@ -67,6 +73,7 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost,
private:
friend class DevToolsAgentHost; // for static methods
+ bool InnerAttach(DevToolsAgentHostClient* client, bool force);
void InnerDetach();
const std::string id_;
« no previous file with comments | « content/browser/devtools/browser_devtools_agent_host.cc ('k') | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698