content/browser/devtools/browser_devtools_agent_host.h - Issue 2047833002: DevTools: introduce browser domain for basic target discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/browser_devtools_agent_host.h

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/devtools_http_handler/devtools_http_handler.cc ('k') | content/browser/devtools/browser_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/browser_devtools_agent_host.h

diff --git a/content/browser/devtools/browser_devtools_agent_host.h b/content/browser/devtools/browser_devtools_agent_host.h

index 8f9bf63a653e06830ef0af98a322b6a7d2afed4f..524322ef48ed45ea65341865851a7405d595a8aa 100644

--- a/content/browser/devtools/browser_devtools_agent_host.h

+++ b/content/browser/devtools/browser_devtools_agent_host.h

@@ -12,6 +12,7 @@ namespace content {

class DevToolsProtocolHandler;

namespace devtools {

+namespace browser { class BrowserHandler; }

namespace io { class IOHandler; }

namespace memory { class MemoryHandler; }

namespace system_info { class SystemInfoHandler; }

@@ -39,6 +40,7 @@ class BrowserDevToolsAgentHost : public DevToolsAgentHostImpl {

bool Close() override;

bool DispatchProtocolMessage(const std::string& message) override;

+ std::unique_ptr<devtools::browser::BrowserHandler> browser_handler_;

std::unique_ptr<devtools::io::IOHandler> io_handler_;

std::unique_ptr<devtools::memory::MemoryHandler> memory_handler_;

std::unique_ptr<devtools::system_info::SystemInfoHandler>