chrome/browser/prerender/prerender_browsertest.cc - Issue 2047833002: DevTools: introduce browser domain for basic target discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | components/devtools_http_handler/devtools_http_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prerender/prerender_browsertest.cc

diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc

index a1b672c3a2471bcf93f9fbcd8be730c04cbcf7ce..5425aac562da8478f25d7308337e359ca7f878ab 100644

--- a/chrome/browser/prerender/prerender_browsertest.cc

+++ b/chrome/browser/prerender/prerender_browsertest.cc

@@ -3226,7 +3226,7 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,

const char* url = "/prerender/prerender_page.html";

PrerenderTestURL(url, FINAL_STATUS_DEVTOOLS_ATTACHED, 1);

NavigateToURLWithDisposition(url, CURRENT_TAB, false);

- agent->DetachClient();

+ agent->DetachClient(&client);

}

// Validate that the sessionStorage namespace remains the same when swapping