content/shell/browser/shell_devtools_frontend.cc - Issue 2047833002: DevTools: introduce browser domain for basic target discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_frontend.cc

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/devtools_agent_host.h ('K') | « content/public/browser/devtools_agent_host.h ('k') | headless/lib/browser/headless_devtools_client_impl.cc » ('j') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_devtools_frontend.cc

diff --git a/content/shell/browser/shell_devtools_frontend.cc b/content/shell/browser/shell_devtools_frontend.cc

index e580e28a7a9ae6ac5b290acf52a76a40b6b8758a..9d45c9219f3d568b92ec239cf372732429b0e03b 100644

--- a/content/shell/browser/shell_devtools_frontend.cc

+++ b/content/shell/browser/shell_devtools_frontend.cc

@@ -143,7 +143,7 @@ void ShellDevToolsFrontend::Close() {

void ShellDevToolsFrontend::DisconnectFromTarget() {

if (!agent_host_)

return;

- agent_host_->DetachClient();

+ agent_host_->DetachClient(this);

agent_host_ = NULL;

}

@@ -177,7 +177,7 @@ void ShellDevToolsFrontend::DocumentAvailableInMainFrame() {

void ShellDevToolsFrontend::WebContentsDestroyed() {

if (agent_host_)

- agent_host_->DetachClient();

+ agent_host_->DetachClient(this);

delete this;

}