content/browser/devtools/devtools_agent_host_impl.h - Issue 2047833002: DevTools: introduce browser domain for basic target discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/browser_devtools_agent_host.cc ('k') | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | content/browser/devtools/protocol/browser_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_agent_host_impl.h

diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h

index f70ebc5fc97dec4bf1cae5315a585aff3634d002..bea3d78c998961d0c35c675ee34c34bcdc1f5249 100644

--- a/content/browser/devtools/devtools_agent_host_impl.h

+++ b/content/browser/devtools/devtools_agent_host_impl.h

@@ -38,8 +38,9 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost,

bool Inspect(BrowserContext* browser_context);

// DevToolsAgentHost implementation.

- void AttachClient(DevToolsAgentHostClient* client) override;

- void DetachClient() override;

+ bool AttachClient(DevToolsAgentHostClient* client) override;

+ bool ForceAttachClient(DevToolsAgentHostClient* client) override;

+ bool DetachClient(DevToolsAgentHostClient* client) override;

bool IsAttached() override;

void InspectElement(int x, int y) override;

std::string GetId() override;

@@ -67,6 +68,7 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost,

private:

friend class DevToolsAgentHost; // for static methods

+ bool InnerAttach(DevToolsAgentHostClient* client, bool force);

void InnerDetach();

const std::string id_;