components/devtools_http_handler/devtools_http_handler.cc - Issue 2047833002: DevTools: introduce browser domain for basic target discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_http_handler/devtools_http_handler.cc

Issue 2047833002: DevTools: introduce browser domain for basic target discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | content/browser/devtools/browser_devtools_agent_host.h » ('j') | content/browser/devtools/protocol/browser_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_http_handler/devtools_http_handler.cc

diff --git a/components/devtools_http_handler/devtools_http_handler.cc b/components/devtools_http_handler/devtools_http_handler.cc

index a5b173afcc4f48540e7883de704010db2e0f7892..87b3d688f406658f3fad9a2aba7589e146dbbc75 100644

--- a/components/devtools_http_handler/devtools_http_handler.cc

+++ b/components/devtools_http_handler/devtools_http_handler.cc

@@ -277,7 +277,7 @@ class DevToolsAgentHostClientImpl : public DevToolsAgentHostClient {

~DevToolsAgentHostClientImpl() override {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (agent_host_.get())

- agent_host_->DetachClient();

+ agent_host_->DetachClient(this);

}

void AgentHostClosed(DevToolsAgentHost* agent_host,