DevTools: introduce browser domain for basic target discovery.

content/public/browser/devtools_agent_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_AGENT_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_AGENT_HOST_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 90 matching lines @@
       scoped_refptr<base::SingleThreadTaskRunner> tethering_task_runner,
       const CreateServerSocketCallback& socket_callback);
 
   static bool IsDebuggerAttached(WebContents* web_contents);
 
   typedef std::vector<scoped_refptr<DevToolsAgentHost> > List;
 
   // Returns all possible DevToolsAgentHosts.
   static List GetOrCreateAll();
 
-  // Client attaches to this agent host to start debugging it.
-  virtual void AttachClient(DevToolsAgentHostClient* client) = 0;
+  // Attaches |client| to this agent host to start debugging.

[dgozman, 2016/06/08 03:53:29]

Let's comment when this may return false.

[pfeldman, 2016/06/08 15:54:52]

Done.

+  virtual bool AttachClient(DevToolsAgentHostClient* client) = 0;
+
+  // Attaches |client| to this agent host to start debugging. Disconnects
+  // any existing clients.
+  virtual bool ForceAttachClient(DevToolsAgentHostClient* client) = 0;

[dgozman, 2016/06/08 03:53:29]

Can this ever return false?

[pfeldman, 2016/06/08 15:54:53]

Done.

 
   // Already attached client detaches from this agent host to stop debugging it.
-  virtual void DetachClient() = 0;
+  virtual bool DetachClient(DevToolsAgentHostClient* client) = 0;
 
   // Returns true if there is a client attached.
   virtual bool IsAttached() = 0;
 
   // Sends a message to the agent. Returns true if the message is handled.
   virtual bool DispatchProtocolMessage(const std::string& message) = 0;

[dgozman, 2016/06/08 03:53:29]

Let's add client parameter here as well, to be sure we handle messages from the
current client.
It will also help later with multi-client.

[pfeldman, 2016/06/08 15:54:52]

Done.

 
   // Starts inspecting element at position (|x|, |y|) in the specified page.
   virtual void InspectElement(int x, int y) = 0;
 
   // Returns the unique id of the agent.
   virtual std::string GetId() = 0;
 
   // Returns web contents instance for this host if any.
   virtual WebContents* GetWebContents() = 0;
 
@@ skipping 32 matching lines @@
   static void RemoveAgentStateCallback(const AgentStateCallback& callback);
 
  protected:
   friend class base::RefCounted<DevToolsAgentHost>;
   virtual ~DevToolsAgentHost() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DEVTOOLS_AGENT_HOST_H_