Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2047813006: Make the CSSCursorImageValue::create() method return a const pointer (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 5 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the CSSCursorImageValue::create() method return a const pointer This is part of a larger effort to make all CSSValue::create() methods return const pointers. BUG=526586 Committed: https://crrev.com/e91b4fc140c59a527d80da59acce3019046bfb32 Cr-Commit-Position: refs/heads/master@{#406147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/css/CSSCursorImageValue.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
sashab
Thoughts on overall approach? :^)
4 years, 6 months ago (2016-06-09 04:43:37 UTC) #2
sashab
Thoughts Elliott? :)
4 years, 5 months ago (2016-07-18 03:23:54 UTC) #4
esprehn
lgtm
4 years, 5 months ago (2016-07-18 21:29:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2047813006/1
4 years, 5 months ago (2016-07-18 21:30:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 23:45:31 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 23:47:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e91b4fc140c59a527d80da59acce3019046bfb32
Cr-Commit-Position: refs/heads/master@{#406147}

Powered by Google App Engine
This is Rietveld 408576698